-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/source: use import error #211
Conversation
uses the more broad ImportError instead of ModuleNotFoundError reasoning being if some submodule (the one I'm configuring currently is my.twitter.twint) doesn't have additional imports from another parser/DAL, but it still has a config block, the user would have to create a stub-config block in their config to use the all.py file
To compare: before this PR, it fails since I dont have twint configured
After this PR:
After I disable it in
|
I guess in the case of But could probably just check the
|
ooh, yeah good idea, let's try that? |
Extracted it out into a helper so it could be used in both
|
Hmm -- seems to be an apt issue or something? May have been a temporary failure - perhaps retry in a bit |
ah, annoying, yeah it happened to be a couple of times before. I'll nudge and merge tomorrow morning! |
uses the more broad ImportError
instead of ModuleNotFoundError
reasoning being if some submodule
(the one I'm configuring currently is
my.twitter.twint) doesn't have additional
imports from another parser/DAL, but it
still has a config block, the user would
have to create a stub-config block in their
config to use the all.py file
I had originally made this ModuleNotFoundError
since reddit had pushshift_comment_export,
so the assumption was that there was an additional
module that could make this fail when additional
sources are used, but that ignores this case when
its just a single file module, not calling out
to some library to handle parsing