Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling mistakes #76

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Conversation

seanbreckenridge
Copy link
Contributor

@seanbreckenridge seanbreckenridge commented Sep 6, 2020

Couple spelling mistake fixes patched back from my fork. These are all in comments.

Theres another spelling mistake here, (commited_dt -> committed_dt) but its part of the NamedTuple definition, so I didn't change it; just wanted to let you know incase you wanted to do something about it. (perhaps a @property wrapper to maintain backwards compatability? maybe thats pushing it)

@karlicoss karlicoss merged commit 7848915 into karlicoss:master Sep 6, 2020
@karlicoss
Copy link
Owner

Thanks!

perhaps a @Property wrapper to maintain backwards compatability?

Yep, I think this is the way to go with such things. This particular module is probably used by very few people, but I guess best not to break it unless absolutely necessary.

Also a deprecation warning would be nice, I was thinking of using something like https://github.com/tantale/deprecated library, or just vendorizing a small, simple decorator to avoid an extra core dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants