Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: sidebar issues on certain sites (e.g. truncation/scrolling/etc) #102

Closed
4 tasks
karlicoss opened this issue May 24, 2020 · 2 comments · Fixed by #308
Closed
4 tasks

extension: sidebar issues on certain sites (e.g. truncation/scrolling/etc) #102

karlicoss opened this issue May 24, 2020 · 2 comments · Fixed by #308
Labels
add-test Something that can be good to add to the test suite ui Related to browser UI

Comments

@karlicoss
Copy link
Owner

karlicoss commented May 24, 2020

Feel free to comment here if you find more such examples

@karlicoss karlicoss added the ui Related to browser UI label May 24, 2020
@bepolymathe
Copy link

Hi @karlicoss,
Just another site with same issue for me
https://www.quaternum.net
I notice that these two sites are static blogs generated by Jekyll 🤔

@karlicoss karlicoss added the add-test Something that can be good to add to the test suite label Nov 20, 2020
@karlicoss karlicoss changed the title Sidebar issues on certain sites (e.g. truncation) Sidebar issues on certain sites (e.g. truncation/scrolling/etc) Nov 20, 2020
@karlicoss karlicoss changed the title Sidebar issues on certain sites (e.g. truncation/scrolling/etc) extension: sidebar issues on certain sites (e.g. truncation/scrolling/etc) Nov 20, 2020
@yoyurec
Copy link
Contributor

yoyurec commented May 1, 2022

https://www.arthurperret.fr/blog/2022-04-11-pourquoi-tenir-un-blog-scientifique.html (@bepolymathe)
same for Hypothesis, so potentially site markup is somehow unusual

they have own styles for IFRAME - margin, max-height, etc...
as devs we can reset it in extension\src\sidebar-outer.css, as users in options page css:

.promnesia-sidebar-active #promnesia-frame {
    margin: 0;
    padding: 0;
    max-width: none;
    max-height: none;
}

https://www.quaternum.net/ (@bepolymathe)

will be fixed with #308


https://www.bloomberg.com/europe (might be behind popups)

will be fixed with #308


https://psychonautwiki.org/wiki/Cannabidiol (sidebar detaches when scrolled)

their BODY has transform: translateZ(0); which un-fix sidebar ((
https://stackoverflow.com/questions/15194313/transform3d-not-working-with-position-fixed-children

as devs we can reset it in extension\src\sidebar-outer.css, as users in options page css:

body.promnesia-sidebar-active {
    transform: none;
}

...but will it safe for other sites? IMHO yes - only crazy sites will use transform on body ))
and extension will apply styles only when sidebar opened!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-test Something that can be good to add to the test suite ui Related to browser UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants