Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar more css classes and styles #308

Merged
merged 1 commit into from
May 1, 2022
Merged

Sidebar more css classes and styles #308

merged 1 commit into from
May 1, 2022

Conversation

yoyurec
Copy link
Contributor

@yoyurec yoyurec commented May 1, 2022 •
edited
Loading

  • Fixes extension: sidebar issues on certain sites (e.g. truncation/scrolling/etc) #102
  • Added more classes to markup for deeper restyling possibilities
  • Header "sticky", only visits scrolled
  • Added '.button' styles
  • Main buttons more recognisible - with emoji icons
  • Added badges counter for sources filter
  • Added active status for "Mark visited" button
  • Added active status for selected source filter (!)
  • Reworked a lot of styling for #visits elements
    • bookmark source items with icon ⭐
    • box colors
    • timestamp monospaced font
  • Text/bg/border colors use CSS variables

Before:
1

After:
image

@yoyurec yoyurec mentioned this pull request May 1, 2022
Closed
@yoyurec yoyurec force-pushed the feature-sidebar-restyling branch from 3776097 to a573e93 Compare May 1, 2022 11:26
@yoyurec yoyurec mentioned this pull request May 1, 2022
Closed
4 tasks
@yoyurec yoyurec force-pushed the feature-sidebar-restyling branch from a573e93 to f424034 Compare May 1, 2022 13:23
karlicoss
karlicoss reviewed May 1, 2022
View reviewed changes
extension/webpack.config.js Outdated
@@ -10,7 +10,7 @@ const T = {
};

const env = {
TARGET : process.env.TARGET,
TARGET : process.env.TARGET || T.CHROME,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should leave it out, would be nice to figure out why the ./build script not working. Might result in some nasty bugs in tests etc..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean delete?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you could keep it locally but not commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully just this left :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gone )

extension/src/options.js Outdated Show resolved Hide resolved
extension/src/sidebar.css Outdated Show resolved Hide resolved
extension/src/sidebar.css Outdated Show resolved Hide resolved
extension/src/sidebar.js Outdated Show resolved Hide resolved
extension/src/sidebar.css Outdated Show resolved Hide resolved
extension/src/sidebar.css Outdated Show resolved Hide resolved
extension/src/sidebar.css Outdated Show resolved Hide resolved
extension/src/sidebar.css Outdated Show resolved Hide resolved
extension/src/sidebar-outer.css Show resolved Hide resolved
@yoyurec yoyurec force-pushed the feature-sidebar-restyling branch 6 times, most recently from 001f8fb to 7176904 Compare May 1, 2022 15:15
karlicoss
karlicoss reviewed May 1, 2022
View reviewed changes
extension/src/sidebar.css Outdated Show resolved Hide resolved
extension/src/sidebar.css Outdated Show resolved Hide resolved
yoyurec
yoyurec commented May 1, 2022
View reviewed changes
extension/src/sidebar.js Outdated Show resolved Hide resolved
@yoyurec yoyurec force-pushed the feature-sidebar-restyling branch 7 times, most recently from 975f862 to 5c97a63 Compare May 1, 2022 19:24
@yoyurec
Copy link
Contributor Author

yoyurec commented May 1, 2022

phew... looks like all comments + few new spotted things fixed!

karlicoss
karlicoss requested changes May 1, 2022
View reviewed changes
extension/src/sidebar.js Outdated Show resolved Hide resolved
extension/webpack.config.js Outdated
@@ -10,7 +10,7 @@ const T = {
};

const env = {
TARGET : process.env.TARGET,
TARGET : process.env.TARGET || T.CHROME,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully just this left :)

@yoyurec yoyurec force-pushed the feature-sidebar-restyling branch from 5c97a63 to ed11e55 Compare May 1, 2022 20:46
@yoyurec yoyurec requested a review from karlicoss May 1, 2022 20:49
@yoyurec yoyurec force-pushed the feature-sidebar-restyling branch from ed11e55 to 5f24cb9 Compare May 1, 2022 20:50
karlicoss
karlicoss approved these changes May 1, 2022
View reviewed changes
Copy link
Owner

@karlicoss karlicoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks so much! 🎉
will merge once CI completes

@karlicoss karlicoss merged commit f23103d into karlicoss:master May 1, 2022
@yoyurec yoyurec deleted the feature-sidebar-restyling branch May 1, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlicoss karlicoss karlicoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extension: sidebar issues on certain sites (e.g. truncation/scrolling/etc)
2 participants
@yoyurec @karlicoss