sources.browser: switch to use HPI + seanbreckenridge/browserexport #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seanbreckenridge just fyi -- your module worked great, only had to add durations :) |
…wserexport later will rename to browser, and implement defensive fallback onto browser_old adapted from https://github.com/seanbreckenridge/promnesia/blob/master/promnesia_sean/sources/browsing.py related: #339 Old vs new modules produce almost identical results (tested on various chrome & firefox databases) There are some minor differences vs the old module: - old database timestamps end with +00:00 UTC, new ones with +00:00 -- likely because browserexport is using timezone.utc instead of pytz - previously locator was pointing at the database file, now it's pointing at the URL I guess it's not necessarily in the 'spirit' of locator field, but on the other hand, not that it's very useful to point to an sqlite file either. Perhaps later it could be in some sort of extra debug field instead.
karlicoss
force-pushed
the
wip-new-browser-export
branch
4 times, most recently
from
c8f325e
to
3c10b6e
Compare
- if my.browser.export is available try to hack HPI config and use it - if not, fallback to promnesia.sources.browser_old
karlicoss
force-pushed
the
wip-new-browser-export
branch
from
3c10b6e
to
57cc779
Compare
|
Heh, didn't believe I'd make this |
also switch it to use ast module -- much easier & quicker to run
|
Switch was trivial 👍 , index looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
later will rename to browser, and implement defensive fallback onto browser_legacy
adapted from https://github.com/seanbreckenridge/promnesia/blob/master/promnesia_sean/sources/browsing.py
related: #339
Old vs new modules produce almost identical results (tested on all of my chrome & firefox databases). The only minor differences are:
old database timestamps end with +00:00 UTC, new ones with +00:00 -- likely because browserexport is using timezone.utc instead of pytz
previously locator was pointing at the database file, now it's pointing at the URL
I guess it's not necessarily in the 'spirit' of locator field, but on the other hand, not that it's very useful to point to an sqlite file either.
Perhaps later it could be in some sort of extra debug field instead.