Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better connection #24

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

Conversation

carlocorradini
Copy link
Collaborator

Fix #11

@carlocorradini
Copy link
Collaborator Author

@karljj1 The goal of this PR is to improve connection by providing a better connection class and a connection builder:

  • IPv4 and IPv6 support
  • Receive and Send network interface by name (e.g. eth0) or by address (e.g. 192.168.0.100)
  • ... More!

@carlocorradini carlocorradini marked this pull request as ready for review October 31, 2023 07:19
@carlocorradini carlocorradini marked this pull request as draft October 31, 2023 07:23
@karljj1
Copy link
Owner

karljj1 commented Oct 31, 2023

Looks like there's some test failures.

@carlocorradini
Copy link
Collaborator Author

Yes, it's only a starting point ☝️

@carlocorradini
Copy link
Collaborator Author

@karljj1 See net_interface and ip_address examples.
These classes will be used as the basis.
Let me know what you think

Copy link
Owner

@karljj1 karljj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@carlocorradini carlocorradini marked this pull request as ready for review November 16, 2023 14:06
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@carlocorradini carlocorradini marked this pull request as draft November 16, 2023 14:13
@carlocorradini
Copy link
Collaborator Author

@karljj1 Can you help me refactor Connection class? Thanks 🥳

@karljj1
Copy link
Owner

karljj1 commented Nov 19, 2023

Sure. What are you thinking?

@carlocorradini
Copy link
Collaborator Author

There is the need to rewrite the connection class:

  • Use new IPAddress class
  • Use new NetworkInterface class
  • Use new Util::Error class instead of checking the error code (and test error) manually
  • Replace old/deprecated structures

PS: Any idea how to integrate connection builder class with connection class?

@karljj1
Copy link
Owner

karljj1 commented Dec 1, 2023

There is the need to rewrite the connection class:

  • Use new IPAddress class
  • Use new NetworkInterface class
  • Use new Util::Error class instead of checking the error code (and test error) manually
  • Replace old/deprecated structures

PS: Any idea how to integrate connection builder class with connection class?

Hey sorry, not had a chance to look at this yet. Im going to be away for most of December but ill take a look in January.

@carlocorradini
Copy link
Collaborator Author

@karljj1 Any update? 🥳

@karljj1
Copy link
Owner

karljj1 commented Feb 7, 2024

Sorry it's been a busy year. I don't really have any strong feelings about this. The connection class was always supposed to be something simple to get you started. If you need something more advanced it's probably better to use an existing open source network library. Maybe we could integrate one as an optional feature if someone needs something more advanced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection builder pattern
3 participants