-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better connection #24
base: master
Are you sure you want to change the base?
Conversation
@karljj1 The goal of this PR is to improve connection by providing a better connection class and a connection builder:
|
Looks like there's some test failures. |
Yes, it's only a starting point ☝️ |
@karljj1 See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
@karljj1 Can you help me refactor |
Sure. What are you thinking? |
There is the need to rewrite the connection class:
PS: Any idea how to integrate connection builder class with connection class? |
Hey sorry, not had a chance to look at this yet. Im going to be away for most of December but ill take a look in January. |
@karljj1 Any update? 🥳 |
Sorry it's been a busy year. I don't really have any strong feelings about this. The connection class was always supposed to be something simple to get you started. If you need something more advanced it's probably better to use an existing open source network library. Maybe we could integrate one as an optional feature if someone needs something more advanced? |
Fix #11