Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Sensitivy Broken #501

Closed
anotherhobby opened this issue Apr 28, 2023 · 3 comments
Closed

Manual Sensitivy Broken #501

anotherhobby opened this issue Apr 28, 2023 · 3 comments

Comments

@anotherhobby
Copy link

When/where was the bug introduced?
0.8.3 Building directly from source.
Manual sensitivity (autosens = 0) does not work at all in version 0.8.3 (bars do not move at all)
The bars do move in 0.8.2, but they just keep growing upward continuously, so also not functional

Describe the bug
When autosens is disabled, all the bars remain flat at the bottom and do not ever move. Switch autosens to enabled, refresh, and the bars immediately start moving as expected. This happens in both ncurses and sdl.

To Reproduce
This simple config below produces bars that do not move at all.
If you change autosens to 1 instead of 0, it immediately works fine and bars start dancing.
I've tried this with 3 different alsa input cards.

[general]
autosens = 0
sensitivity = 100
[input]
method = alsa
source = hw:CODEC
[output]
method = ncurses

Expected behavior
autosens = 0 should prevent the bars from changing sensitivity

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Raspbian
  • Version: 10 (buster)

Terminal emulator
Built-in

@karlstav
Copy link
Owner

confirmed, working on fix

karlstav added a commit that referenced this issue Apr 30, 2023
this was accidentally removed in fb40732

references to average max removed, was not used. do not rememeber
what it was for.
@karlstav
Copy link
Owner

hi @anotherhobby ,

thanks for the bug report, I did break this functionality pretty bad (simply commented out while debugging something else and then committed by accident) .

Should be fixed now!

@anotherhobby
Copy link
Author

Awesome! Just tested and can also confirm it works great now. Thank you very much, and that was crazy fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants