Skip to content

Commit 027fa4f

Browse files
committed
feat: add a default config and normalize outputFile path
We used to do this in Karma's config, but it really belongs here.
1 parent 3de66aa commit 027fa4f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/reporter.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ Store.mix(BasePathStore, {
3939
// TODO(vojta): inject only what required (config.basePath, config.coverageReporter)
4040
var CoverageReporter = function(rootConfig, helper, logger) {
4141
var log = logger.create('coverage');
42-
var config = rootConfig.coverageReporter;
42+
var config = rootConfig.coverageReporter || {};
4343
var basePath = rootConfig.basePath;
44-
var outDir = config.dir;
44+
var outDir = helper.normalizeWinPath(path.resolve(basePath, config.dir || 'coverage'));
4545
var reporters = config.reporters;
4646

4747
if (!helper.isDefined(reporters)) {
@@ -82,7 +82,7 @@ var CoverageReporter = function(rootConfig, helper, logger) {
8282
}
8383

8484
pendingFileWritings++;
85-
helper.mkdirIfNotExists(path.resolve(outDir), function() {
85+
helper.mkdirIfNotExists(outDir, function() {
8686
var now = dateformat(new Date(), 'yyyymmdd_HHMMss');
8787
var name = 'coverage-' + browser.name + '-' + now + '.json';
8888
fs.writeFile(path.join(outDir, name), JSON.stringify(collector.getFinalCoverage()), 'utf8', function(err) {
@@ -114,7 +114,7 @@ var CoverageReporter = function(rootConfig, helper, logger) {
114114
basePath : basePath
115115
})
116116
});
117-
var reporter = istanbul.Report.create(reporterConfig.type, options);
117+
var reporter = istanbul.Report.create(reporterConfig.type || 'html', options);
118118
try {
119119
reporter.writeReport(collector, true);
120120
} catch (e) {

0 commit comments

Comments
 (0)