fix(config): Wait 30s for browser activity per Travis. #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I only discovered this when trying to further debug the fails. |
johnjbarton
force-pushed
the
phantomjs-disconnect-30
branch
from
c6f76c0
to
8c458e7
Compare
zzo
reviewed
Jul 27, 2018
|
Yes, 10s was the previous default. 30s is too high for local testing, but CI machines are much slower. |
zzo
reviewed
Jul 27, 2018
| @@ -343,7 +343,7 @@ class Config { | |||
| } | |||
| this.browserDisconnectTimeout = 2000 | |||
| this.browserDisconnectTolerance = 0 | |||
| this.browserNoActivityTimeout = 20000 | |||
There was a problem hiding this comment.
yea, in #3087 two days ago I set it to 20s. Then I saw the travis page recommending 30s. bah.
zzo
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.travis-ci.com/user/gui-and-headless-browsers/#karma-and-firefox-inactivity-timeouts