Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO List: Enhance Cluster Lifecycle Management #1762

Closed
4 tasks done
Garrybest opened this issue May 10, 2022 · 5 comments · Fixed by #2391
Closed
4 tasks done

TODO List: Enhance Cluster Lifecycle Management #1762

Garrybest opened this issue May 10, 2022 · 5 comments · Fixed by #2391
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Garrybest
Copy link
Member

Garrybest commented May 10, 2022

What would you like to be added:
According to #1640 (comment), I'd like to enhance cluster lifecycle management. Here is the todo-list.

Why is this needed:
Move some functions away from scheduler and make the scheduler more concise.

@RainbowMango
Copy link
Member

Hi @Garrybest
I guess the task(Remove cluster scheduling result in spec.clusters when the cluster is terminating.) is included in #1945.

Should we update the task list?

@Garrybest
Copy link
Member Author

Hi @Garrybest I guess the task(Remove cluster scheduling result in spec.clusters when the cluster is terminating.) is included in #1945.

Should we update the task list?

Well, I'm afraid not. This task is to drain a cluster by using NoExecute taint when we decide to unjoin it, while #1945 focuses on how taint manager works.

@Garrybest
Copy link
Member Author

Garrybest commented Jun 11, 2022

I have an idea. Maybe we could implement this in cmd karmadactl drain. Just like what kubectl drain does, when we want to unjoin a cluster, we cordon this cluster first and then remove RB's cluster scheduling result in spec.clusters. At last, we use karmadactl unjoin.

@XiShanYongYe-Chang
Copy link
Member

/assign @Garrybest

@Garrybest Garrybest moved this to In Progress in Karmada Release 1.3 Aug 22, 2022
Repository owner moved this from In Progress to Done in Karmada Release 1.3 Aug 22, 2022
@RainbowMango
Copy link
Member

Great thanks to @Garrybest !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants