skipped Event api does not take effect

[XiShanYongYe-Chang]

What happened:

When I set --skipped-propagating-apis to karmada-controller-manager such as:

- --skipped-propagating-apis=v1/Event

It dose not take effect. In karmada-controller-manager logs file, still have Event info with detector:

detector.go:721] Add object(events.k8s.io/v1, kind=Event, default/serviceimports.multicluster.x-k8s.io-customresourcedefinition.16b3b14e05fa7351) to waiting list, length of list is: 207

What you expected to happen:

The setting take effect.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• Karmada version: master branch
• Others:

[XiShanYongYe-Chang]

/help

[karmada-bot]

@XiShanYongYe-Chang:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Charlie17Li]

/assign

[dddddai]

The flag works fine in my environment, you specified v1/Event but not events.k8s.io/v1/Event

[XiShanYongYe-Chang]

Hi @dddddai , the log contains both v1/Event and events.k8s.io/v1/Event:

I1102 09:41:59.395795       1 detector.go:202] Reconciling object: events.k8s.io/v1, kind=Event, karmadatest-gbc/hello-2h9-serviceexport.16b3b1526f3ffe0f
I1102 09:41:59.495415       1 detector.go:202] Reconciling object: v1, kind=Event, karmadatest-gbc/hello-2h9-serviceexport.16b3b1526f3ffe0f

[XiShanYongYe-Chang]

# kubectl  get events -n karmada-es-member1 nginx-687f7fb96f.16b3b640ae370302 -oyaml
apiVersion: v1
kind: Event
lastTimestamp: "2021-11-02T11:11:18Z"
message: Sync work (nginx-687f7fb96f) to cluster(member1) successful.
...

[XiShanYongYe-Chang]

I try with --skipped-propagating-apis=events.k8s.io/v1/Event, but it doesn't work on my side.

[dddddai]

That's flaky, there's no such log in my environment

BTW, why is there a event in karmada-es-member1?
Only works exist in this namespace, don't they? Please correct me if I'm wrong

[XiShanYongYe-Chang]

why is there a event in karmada-es-member1?

Yeah, I create a deployment and propagate it to member clusters:

# kubectl  get work -A
NAMESPACE            NAME               AGE
karmada-es-member1   nginx-687f7fb96f   31m
karmada-es-member2   nginx-687f7fb96f   31m

[dddddai]

Let me fetch upstream and try again...

[pigletfly]

Event belongs to corev1.I use - --skipped-propagating-apis=v1/Node,Event,Pod,PersistentVolume,ConfigMap,Endpoints,PersistentVolumeClaim;apiextensions.k8s.io/v1;events.k8s.io/v1beta1;discovery.k8s.io/v1beta1;rbac.authorization.k8s.io/v1 works for me

[pigletfly]

@XiShanYongYe-Chang can you try config above ?

[dddddai]

Oh, after I fetched upstream, this happens, I suspect it's because this commit deletes skippedResourceConfig.Parse when initializing karmada-controller-manager, which makes the flag NOT work

This change doesn't make sense to me.

[RainbowMango]

Right, #881 omitted the parse() action, so all configurations made by --skipped-propagating-apis are ignored.
cc @learner0810

[learner0810]

@RainbowMango This issue has been fixed. @XiShanYongYe-Chang I'm really sorry for the trouble caused to you by this problem

[RainbowMango]

No worries, I didn't notice it as well.

[XiShanYongYe-Chang]

I'm really sorry for the trouble caused to you by this problem

It's okay, I just wanted to try this feature. :)