Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop resync for controllers #1265

Merged
merged 1 commit into from
Jan 21, 2022
Merged

stop resync for controllers #1265

merged 1 commit into from
Jan 21, 2022

Conversation

Garrybest
Copy link
Member

@Garrybest Garrybest commented Jan 17, 2022 •
edited by RainbowMango
Loading

Signed-off-by: Garrybest garrybest@foxmail.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
It is a temporary solution. Should be rebased into release-1.0.

Which issue(s) this PR fixes:
Fixes #1260 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixed controller resync slow down reconcile issue.

@Garrybest
set resync period to 0
cae5433 
Signed-off-by: Garrybest <garrybest@foxmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 17, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2022
@RainbowMango
Copy link
Member

/retitle stop resync for controllers

@karmada-bot karmada-bot changed the title set resync period to 0 stop resync for controllers Jan 17, 2022
@RainbowMango
Copy link
Member

/release-note-edit release-note Fixed controller resync slow down reconcile issue.

@RainbowMango
Copy link
Member

Sorry, we haven't enabled the release note plugin yet.

Let's manually update the release note this time.

@RainbowMango
Copy link
Member

/kind bug

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 17, 2022
@RainbowMango
Copy link
Member

LGTM.
Have you ever verified this in your production environment?

@Garrybest
Copy link
Member Author

Garrybest commented Jan 17, 2022 •
edited
Loading

Not yet. Only test it locally in my kind cluster. I will make a confirmation sooner.

@XiShanYongYe-Chang
Copy link
Member

I test this on my local, It does work!

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jan 20, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
RainbowMango
RainbowMango approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@XiShanYongYe-Chang Please help cherry-pick this to release-1.0.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@karmada-bot karmada-bot merged commit 7c78d03 into karmada-io:master Jan 21, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Jan 21, 2022
Merged
@Garrybest Garrybest deleted the pr_resync branch January 21, 2022 02:12
@RainbowMango RainbowMango added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 21, 2022
karmada-bot added a commit that referenced this pull request Jan 21, 2022
@karmada-bot
Merge pull request #1295 from XiShanYongYe-Chang/automated-cherry-pic…
ce2267c 
…k-of-#1265-upstream-release-1.0

Automated cherry pick of #1265: set resync period to 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resource status aggregating slow down due to informer resync
4 participants
@Garrybest @RainbowMango @XiShanYongYe-Chang @karmada-bot