Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm chart] fix version constraints skip prerelease issue #1444

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[helm chart] fix version constraints skip prerelease issue #1444

merged 1 commit into from
Mar 10, 2022

Conversation

pigletfly
Copy link
Contributor

@pigletfly pigletfly commented Mar 7, 2022 •
edited by RainbowMango
Loading

Signed-off-by: pigletfly wangbing.adam@gmail.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1339

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`helm-chart`: fix version constraints skip pre-releases issue.

@karmada-bot karmada-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Mar 7, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2022
@pigletfly
Copy link
Contributor Author

pigletfly commented Mar 7, 2022 •
edited
Loading

xref https://github.com/Masterminds/semver#working-with-prerelease-versions, which is used by Helm

@pigletfly
Fix helm charts k8s version check
59798d2 
Signed-off-by: pigletfly <wangbing.adam@gmail.com>
@RainbowMango
Copy link
Member

SemVer comparisons using constraints without a prerelease comparator will skip prerelease versions. For example, >=1.2.3 will skip prereleases when looking at a list of releases while >=1.2.3-0 will evaluate and find prereleases.

Yeah, that might be the reason.

@RainbowMango
Copy link
Member

/retitle [helm chart] fix version constraints skip prerelease issue

@karmada-bot karmada-bot changed the title Fix helm charts k8s version check [helm chart] fix version constraints skip prerelease issue Mar 9, 2022
@karmada-bot karmada-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 9, 2022
@RainbowMango
Copy link
Member

@pigletfly Have you tested it? I don't have the environment.

@pigletfly
Copy link
Contributor Author

yes

RainbowMango
RainbowMango reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
cc @jrkeen @7Bytes
I guess you guys need to know it.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
RainbowMango
RainbowMango approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@karmada-bot karmada-bot merged commit 7c0ebc3 into karmada-io:master Mar 10, 2022
@RainbowMango
Copy link
Member

@XiShanYongYe-Chang Can you help pick this to release branches?

@XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang Can you help pick this to release branches?

Ok, I will do it.

@pigletfly pigletfly deleted the fix-helm-k8s-version branch March 10, 2022 08:47
This was referenced Mar 10, 2022
Merged
Merged
karmada-bot added a commit that referenced this pull request Mar 10, 2022
@karmada-bot
Merge pull request #1465 from XiShanYongYe-Chang/automated-cherry-pic…
ae2a4e0 
…k-of-#1444-upstream-release-1.1

Automated cherry pick of #1444: Fix helm charts k8s version check
karmada-bot added a commit that referenced this pull request Mar 10, 2022
@karmada-bot
Merge pull request #1466 from XiShanYongYe-Chang/automated-cherry-pic…
7f7899a 
…k-of-#1444-upstream-release-1.0

Automated cherry pick of #1444: Fix helm charts k8s version check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@jrkeen jrkeen Awaiting requested review from jrkeen

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chart requires kubeVersion: >=1.16.0 which is incompatible with Kubernetes v1.21.5-eks-bc4871b
4 participants
@pigletfly @RainbowMango @karmada-bot @XiShanYongYe-Chang