Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix karmadactl taint failed #1825

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

wuyingjun-lucky
Copy link
Member

@wuyingjun-lucky wuyingjun-lucky commented May 18, 2022

Signed-off-by: wuyingjun wuyingjun_yewu@cmss.chinamobile.com

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix karmadactl taint failed
Which issue(s) this PR fixes:
Fixes #1823

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: fixed karmadactl can not taint while karmada control plane config is not located on default path

Signed-off-by: wuyingjun <wuyingjun_yewu@cmss.chinamobile.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 18, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2022
@lonelyCZ
Copy link
Member

Thanks, @wuyingjun-lucky

/lgtm

And I think this patch should be picked to release branches. @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@RainbowMango
Copy link
Member

And I think this patch should be picked to release branches. @RainbowMango

All right.

/approve
/hold
for release notes.(Please add a release note to the PR description.)

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@wuyingjun-lucky
Copy link
Member Author

wuyingjun-lucky commented May 19, 2022

And I think this patch should be picked to release branches. @RainbowMango

All right.

/approve /hold for release notes.(Please add a release note to the PR description.)

karmadactl: fixed karmadactl can not taint while karmada control plane config is not located on default path
@RainbowMango @lonelyCZ please check my description
image

@RainbowMango
Copy link
Member

/hold cancel

Looks good.

Then, please help pick this patch for both release-1.0 and release-1.1.

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2022
@karmada-bot karmada-bot merged commit 97fc9d5 into karmada-io:master May 19, 2022
@wuyingjun-lucky wuyingjun-lucky deleted the taint_bug branch May 19, 2022 12:12
karmada-bot added a commit that referenced this pull request May 20, 2022
…f-#1825-upstream-release-1.0

Automated cherry pick of #1825: fix karmadactl taint failed
karmada-bot added a commit that referenced this pull request May 20, 2022
…f-#1825-upstream-release-1.1

Automated cherry pick of #1825: fix karmadactl taint failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

karmadactl taint failed
4 participants