-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package subcommands of karmadactl to make it clearer #2664
Package subcommands of karmadactl to make it clearer #2664
Conversation
Please assign it to me after you fixed the CI. |
This job will make the package of karmadactl clearer, thanks~ |
Hi @lonelyCZ, How about continuing with this refactoring? |
All right, it can be pushed forward after #2694 merged. |
e6e414b
to
165e546
Compare
Codecov Report
@@ Coverage Diff @@
## master #2664 +/- ##
==========================================
+ Coverage 33.37% 38.98% +5.61%
==========================================
Files 200 187 -13
Lines 19750 16897 -2853
==========================================
- Hits 6591 6588 -3
+ Misses 12765 9914 -2851
- Partials 394 395 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
344ff2e
to
aa2a3c8
Compare
Signed-off-by: lonelyCZ <chengzhe@zju.edu.cn>
aa2a3c8
to
faa6b64
Compare
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Package subcommands of karmadactl to make it clearer, and it is easy to add UT for subcommands.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: