Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package subcommands of karmadactl to make it clearer #2664

Merged

Conversation

lonelyCZ
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Package subcommands of karmadactl to make it clearer, and it is easy to add UT for subcommands.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 20, 2022
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2022
@RainbowMango
Copy link
Member

Please assign it to me after you fixed the CI.

@lonelyCZ
Copy link
Member Author

lonelyCZ commented Oct 21, 2022

Please assign it to me after you fixed the CI.

Ok, I will fix it after #2589 #2610 merged.

@XiShanYongYe-Chang
Copy link
Member

This job will make the package of karmadactl clearer, thanks~

@XiShanYongYe-Chang
Copy link
Member

Hi @lonelyCZ, How about continuing with this refactoring?

@lonelyCZ
Copy link
Member Author

lonelyCZ commented Nov 4, 2022

How about continuing with this refactoring?

All right, it can be pushed forward after #2694 merged.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #2664 (aa2a3c8) into master (393fb9d) will increase coverage by 5.61%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2664      +/-   ##
==========================================
+ Coverage   33.37%   38.98%   +5.61%     
==========================================
  Files         200      187      -13     
  Lines       19750    16897    -2853     
==========================================
- Hits         6591     6588       -3     
+ Misses      12765     9914    -2851     
- Partials      394      395       +1     
Flag Coverage Δ
unittests 38.98% <0.00%> (+5.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/karmadactl/taint/taint.go 43.75% <0.00%> (ø)
pkg/util/worker.go 66.66% <0.00%> (-4.77%) ⬇️
pkg/karmadactl/cmdinit/utils/format.go 9.19% <0.00%> (ø)
pkg/karmadactl/apply/apply.go
pkg/karmadactl/cordon/cordon.go
pkg/karmadactl/deinit/deinit.go
pkg/karmadactl/describe/describe.go
pkg/karmadactl/exec/exec.go
pkg/karmadactl/get/get.go
pkg/karmadactl/join/join.go
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lonelyCZ lonelyCZ force-pushed the pr-package-karmadactl-subcmd branch 2 times, most recently from 344ff2e to aa2a3c8 Compare November 10, 2022 05:46
Signed-off-by: lonelyCZ <chengzhe@zju.edu.cn>
@lonelyCZ
Copy link
Member Author

@RainbowMango
Copy link
Member

/assign
I'll look at it tomorrow.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2022
@RainbowMango RainbowMango added this to the v1.4 milestone Nov 11, 2022
@karmada-bot karmada-bot merged commit f0d1e9b into karmada-io:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants