Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple dependencyInterpreter lua script for one gvk #2884

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Nov 30, 2022

Signed-off-by: changzhen changzhen5@huawei.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support multiple dependencyInterpreter lua script for one gvk resource

Which issue(s) this PR fixes:
Part of #2371

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Users are now able to apply multiple dependencies interpreter configurations.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 30, 2022
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 30, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Support multiple dependencyInterpreter lua script for one gvk [WIP] Support multiple dependencyInterpreter lua script for one gvk Dec 5, 2022
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the support-multiple-denpendent-script branch 2 times, most recently from ed5f931 to 98b783e Compare December 6, 2022 12:31
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title [WIP] Support multiple dependencyInterpreter lua script for one gvk Support multiple dependencyInterpreter lua script for one gvk Dec 6, 2022
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2022
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango @ikaven1024

Copy link
Member

@ikaven1024 ikaven1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the support-multiple-denpendent-script branch 2 times, most recently from d5f2060 to d24f9f0 Compare December 8, 2022 07:16
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2022
@RainbowMango
Copy link
Member

/assign

Signed-off-by: changzhen <changzhen5@huawei.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@karmada-bot karmada-bot merged commit 11cb257 into karmada-io:master Dec 13, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the support-multiple-denpendent-script branch January 13, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants