-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple dependencyInterpreter lua script for one gvk #2884
Support multiple dependencyInterpreter lua script for one gvk #2884
Conversation
ed5f931
to
98b783e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
pkg/resourceinterpreter/configurableinterpreter/dependencyset.go
Outdated
Show resolved
Hide resolved
d5f2060
to
d24f9f0
Compare
d24f9f0
to
73b572a
Compare
/assign |
pkg/resourceinterpreter/configurableinterpreter/configmanager/accessor.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/configurableinterpreter/configurable.go
Outdated
Show resolved
Hide resolved
Signed-off-by: changzhen <changzhen5@huawei.com>
73b572a
to
5ed2100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: changzhen changzhen5@huawei.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support multiple dependencyInterpreter lua script for one gvk resource
Which issue(s) this PR fixes:
Part of #2371
Special notes for your reviewer:
Does this PR introduce a user-facing change?: