-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with Go patch release 1.19.4 #2908
Conversation
Welcome @qingwave! It looks like this is your first PR to karmada-io/karmada 🎉 |
Hi, @qingwave welcome! You can sign off refer to https://github.com/karmada-io/karmada/pull/2908/checks?check_run_id=9931965045 |
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #2908 +/- ##
==========================================
+ Coverage 38.24% 38.29% +0.04%
==========================================
Files 204 204
Lines 18750 18750
==========================================
+ Hits 7171 7180 +9
+ Misses 11151 11144 -7
+ Partials 428 426 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: qingwave <854222409@qq.com>
@XiShanYongYe-Chang @RainbowMango Thank for you review and reminder. Now DCO is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do we need to cherry-pick it to the release-1.4 branch? |
Yes. @qingwave will do that? |
@RainbowMango sure, it's ok for me :) |
…-upstream-release-1.4 Cherry pick from #2908: Build with Go patch release 1.19.4
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2907
Special notes for your reviewer:
Does this PR introduce a user-facing change?: