Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Go patch release 1.19.4 #2908

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

qingwave
Copy link
Contributor

@qingwave qingwave commented Dec 7, 2022

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #2907

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Karmada is now built with Golang 1.19.4.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 7, 2022
@karmada-bot
Copy link
Collaborator

Welcome @qingwave! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2022
@XiShanYongYe-Chang
Copy link
Member

@RainbowMango
Copy link
Member

/lgtm
Waiting for DCO.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Merging #2908 (1aaa4f1) into master (e6ba531) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2908      +/-   ##
==========================================
+ Coverage   38.24%   38.29%   +0.04%     
==========================================
  Files         204      204              
  Lines       18750    18750              
==========================================
+ Hits         7171     7180       +9     
+ Misses      11151    11144       -7     
+ Partials      428      426       -2     
Flag Coverage Δ
unittests 38.29% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/search/proxy/store/util.go 94.31% <0.00%> (+1.42%) ⬆️
pkg/search/proxy/store/store.go 68.42% <0.00%> (+3.15%) ⬆️
pkg/util/worker.go 71.42% <0.00%> (+4.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: qingwave <854222409@qq.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@qingwave
Copy link
Contributor Author

qingwave commented Dec 7, 2022

@XiShanYongYe-Chang @RainbowMango Thank for you review and reminder. Now DCO is done.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@XiShanYongYe-Chang
Copy link
Member

Do we need to cherry-pick it to the release-1.4 branch?

@RainbowMango
Copy link
Member

Yes. @qingwave will do that?
https://karmada.io/docs/contributor/cherry-picks
Here is the guideline on how to do that.

@qingwave
Copy link
Contributor Author

qingwave commented Dec 7, 2022

@RainbowMango sure, it's ok for me :)

@karmada-bot karmada-bot merged commit 9207812 into karmada-io:master Dec 7, 2022
karmada-bot added a commit that referenced this pull request Dec 7, 2022
…-upstream-release-1.4

Cherry pick from #2908: Build with Go patch release 1.19.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with Go patch release 1.19.4
5 participants