-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Connection to ResourceInterpretWebhook without DNS Service #2999
Conversation
Welcome @lxtywypc! It looks like this is your first PR to karmada-io/karmada 🎉 |
8a9cbaf
to
a7c0d24
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #2999 +/- ##
==========================================
- Coverage 51.63% 51.61% -0.03%
==========================================
Files 210 210
Lines 18926 18926
==========================================
- Hits 9773 9769 -4
- Misses 8622 8625 +3
- Partials 531 532 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @lxtywypc, the E2E has failed in the CI, have you tested it on your site? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly ping @lxtywypc
@@ -45,8 +49,23 @@ func NewCustomizedInterpreter(informer genericmanager.SingleClusterInformerManag | |||
if err != nil { | |||
return nil, err | |||
} | |||
|
|||
serviceInformer := informers.NewSharedInformerFactory(kubernetes.NewForConfigOrDie(config), 0).Core().V1().Services() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the input parameters informer
directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it is a dynamic informer, but we need a versioned informer.
Maybe I can use indexer to build a service lister directly, but that need to add a new method to get indexer in interface SingleClusterInformerManager, I don't know if it would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i get it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use the versioned informer to replace the dynamic informer, if this works, we can do it in the next pr.
Humm... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @RainbowMango
The E2E still failing after retrying. @XiShanYongYe-Chang |
Hi @lxtywypc, I test with this pr on my side, after I deployed Karmada, I find that the status condition of the cluster |
Ok, I will check again later |
959fa9a
to
8d1eb7a
Compare
8d1eb7a
to
4bbdf74
Compare
@XiShanYongYe-Chang @RainbowMango |
/assign |
4bbdf74
to
ee33fb8
Compare
ee33fb8
to
ec3f62e
Compare
Thanks, @lxtywypc, can you help compress your commits into one? Ask for @ikaven1024 @RainbowMango to retake a review. |
Ok, but how about vendor? @XiShanYongYe-Chang |
/cc @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test report?
c3ab005
to
fafcaac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
for the test report, since we don't have the test for this scenario.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lxtywypc can you help post your test result here? A simple test process report is enough. |
Hi @XiShanYongYe-Chang , I'm sorry for replying late. |
…minate dependency of DNS Signed-off-by: lxtywypc <lxtywypc@gmail.com>
fafcaac
to
71ffbf4
Compare
Thanks~ I'm sorry, I don't have a specific template here either. My idea is that you can simply explain your local test process and post your test results here will be ok. |
Ok, I'll do it later. |
Here is the test report: Note: Some parts with the information of company in the example has been hidden.
The webhook can be accessed successfully, and we haven't met any other problems yet. |
@lxtywypc a clear test report, thanks a lot. /lgtm Can you help update the release-note, such as:
|
@XiShanYongYe-Chang I'm glad to. But I don't know clearly what I should do. |
We usually synchronize bugs to previous versions, and the current change is more like a feature to us. Do you need to use it in previous versions? |
I don't think we need to cherry-pick this to release branches. |
@XiShanYongYe-Chang @RainbowMango I see. Thanks a lot. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
If we deploy karmada with Default dnsPolicy or deploy karmada in physical machine/virtual machine directly, and there is no coreDNS or other DNS services, it would not connect to resource-interpret-webhooks successfully with DefaultServiceResolver.
Which issue(s) this PR fixes:
Fixes #2998
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: