Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourceRegistry need add scope="Cluster" #3084

Conversation

yanfeng1992
Copy link
Member

@yanfeng1992 yanfeng1992 commented Jan 30, 2023

Signed-off-by: huangyanfeng huangyanfeng1992@gmail.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

When I generate the crd with the following command:controller-gen crd paths=./pkg/apis/search/v1alpha1/... output:crd:dir=./charts/_crds/bases

Generated a crd with the wrong scope

image

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-search: resourceRegistry type add scope="Cluster"

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3084 (3d453c7) into master (28223cf) will increase coverage by 5.39%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3084      +/-   ##
==========================================
+ Coverage   37.90%   43.30%   +5.39%     
==========================================
  Files         207      208       +1     
  Lines       19350    19429      +79     
==========================================
+ Hits         7335     8414    +1079     
+ Misses      11578    10550    -1028     
- Partials      437      465      +28     
Flag Coverage Δ
unittests 43.30% <ø> (+5.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/webhook/configuration/validating.go 71.42% <0.00%> (ø)
pkg/registry/cluster/strategy.go 54.68% <0.00%> (ø)
...g/util/overridemanager/labelannotationoverrider.go 85.29% <0.00%> (+0.44%) ⬆️
pkg/karmadactl/cmdinit/kubernetes/deploy.go 7.53% <0.00%> (+4.27%) ⬆️
pkg/util/validation/validation.go 74.07% <0.00%> (+5.41%) ⬆️
pkg/util/overridemanager/overridemanager.go 48.62% <0.00%> (+25.22%) ⬆️
pkg/apis/cluster/mutation/mutation.go 98.11% <0.00%> (+91.82%) ⬆️
pkg/karmadactl/cmdinit/kubernetes/deployments.go 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yanfeng1992, in Karmada, ResourceRegistry is registered through the Aggregation Layer.
May I ask, why do you need to generate a CRD?

@XiShanYongYe-Chang
Copy link
Member

ResourceRegistry is registered through the Aggregation Layer.

image

@yanfeng1992
Copy link
Member Author

I misunderstood. In addition, did this PR #3044 finally come to a conclusion? @XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

I misunderstood. In addition, did this PR #3044 finally come to a conclusion? @XiShanYongYe-Chang

Let me take a look later.

@yanfeng1992 yanfeng1992 deleted the fixbug_resourceregistry_crd_scope branch April 2, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants