-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resourceRegistry need add scope="Cluster" #3084
resourceRegistry need add scope="Cluster" #3084
Conversation
Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3084 +/- ##
==========================================
+ Coverage 37.90% 43.30% +5.39%
==========================================
Files 207 208 +1
Lines 19350 19429 +79
==========================================
+ Hits 7335 8414 +1079
+ Misses 11578 10550 -1028
- Partials 437 465 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yanfeng1992, in Karmada, ResourceRegistry
is registered through the Aggregation Layer.
May I ask, why do you need to generate a CRD?
|
I misunderstood. In addition, did this PR #3044 finally come to a conclusion? @XiShanYongYe-Chang |
Let me take a look later. |
Signed-off-by: huangyanfeng huangyanfeng1992@gmail.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
When I generate the crd with the following command:controller-gen crd paths=./pkg/apis/search/v1alpha1/... output:crd:dir=./charts/_crds/bases
Generated a crd with the wrong scope
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: