Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmada-search install by helm support specify external etcd #3120

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Feb 7, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #3119

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Chart: karmada-search install support specify external etcd

Signed-off-by: xin.li <xin.li@daocloud.io>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 7, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3120 (0150b5b) into master (8a69413) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #3120   +/-   ##
=======================================
  Coverage   44.48%   44.48%           
=======================================
  Files         208      208           
  Lines       19524    19524           
=======================================
  Hits         8686     8686           
  Misses      10357    10357           
  Partials      481      481           
Flag Coverage Δ
unittests 44.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Poor12
Copy link
Member

Poor12 commented Feb 7, 2023

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poor12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@karmada-bot karmada-bot merged commit 54db4fe into karmada-io:master Feb 7, 2023
@my-git9 my-git9 deleted the fix/external-etcd branch March 6, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart karmada-search don't support external etcd cluster
4 participants