Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3201: fix the bug that the work object may contain uppercase #3213

Conversation

whitewindmills
Copy link
Member

@whitewindmills whitewindmills commented Feb 27, 2023

Cherry pick of #3201 on release-1.2.
#3201: fix the bug that the work object may contain uppercase
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the issue that RBAC resources whose name contains uppercase characters can not be propagated.

Signed-off-by: hejunhua <jayfantasyhjh@gmail.com>
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@karmada-bot karmada-bot merged commit f7e0cc1 into karmada-io:release-1.2 Feb 27, 2023
@whitewindmills whitewindmills deleted the automated-cherry-pick-of-#3201-upstream-release-1.2 branch February 28, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants