-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement propagation policy priority preemption #3837
feat: implement propagation policy priority preemption #3837
Conversation
/cc @Poor12 |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3837 +/- ##
==========================================
- Coverage 55.50% 55.17% -0.34%
==========================================
Files 226 227 +1
Lines 21457 21606 +149
==========================================
+ Hits 11910 11921 +11
- Misses 8911 9049 +138
Partials 636 636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3324efa
to
5e55f62
Compare
5e55f62
to
194d576
Compare
PTAL @RainbowMango @Poor12 |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested it? Can you share the test result here?
Yeah, I'll paste it here. |
|
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
194d576
to
d487e2c
Compare
for
|
PLAT @Poor12 @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leave LGTM to @Poor12
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
implement propagation policy preemption: high-priority pp/cpp -> low-priority pp/cpp.
Which issue(s) this PR fixes:
part of feature
Special notes for your reviewer:
Does this PR introduce a user-facing change?: