Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e coverage analysis docs #4324

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Add e2e coverage analysis docs #4324

merged 1 commit into from
Dec 2, 2023

Conversation

Vacant2333
Copy link
Contributor

What type of PR is this?
/kind documentation

Which issue(s) this PR fixes:
Part of #3685

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 26, 2023
@Vacant2333 Vacant2333 changed the title [e2e] add e2e coverage analysis docs [WIP]add e2e coverage analysis docs Nov 26, 2023
@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf1098b) 52.80% compared to head (d3a87c3) 51.78%.
Report is 63 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4324      +/-   ##
==========================================
- Coverage   52.80%   51.78%   -1.02%     
==========================================
  Files         240      243       +3     
  Lines       23624    24112     +488     
==========================================
+ Hits        12474    12487      +13     
- Misses      10471    10944     +473     
- Partials      679      681       +2
Flag Coverage Δ
unittests 51.78% <ø> (-1.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks a lot~

test/e2e/coverage_docs/clusterpropagationpolicy_test.md Outdated Show resolved Hide resolved
test/e2e/coverage_docs/clusterpropagationpolicy_test.md Outdated Show resolved Hide resolved
test/e2e/coverage_docs/clusterpropagationpolicy_test.md Outdated
Comment on lines 28 to 30
1. May need add the tase case when the [deployment updates](https://karmada.io/docs/next/userguide/scheduling/resource-propagating#update-deployment).
2. May need add the test case for the **same implicit priority** propagation.
3. May need add the test case for **delete** the clusterPropagationPolicy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create an issue to track these tasks in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes~ sure, and its work in progressnow i will add more

@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2023
@Vacant2333 Vacant2333 changed the title [WIP]add e2e coverage analysis docs Add e2e coverage analysis docs Nov 30, 2023
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
@Vacant2333
Copy link
Contributor Author

@XiShanYongYe-Chang @jwcesign neeeed review~

@XiShanYongYe-Chang
Copy link
Member

Thanks @Vacant2333
The CI failed, can you help fix it?

/assign

@jwcesign
Copy link
Member

jwcesign commented Dec 1, 2023

Hi, @Vacant2333 ,
The ci is fixed, can you rebase the newest code?

@Vacant2333
add e2e coverage analysis
d3a87c3 
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 2, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2023
@karmada-bot karmada-bot merged commit d43f22f into karmada-io:master Dec 2, 2023
12 checks passed
@Vacant2333
Copy link
Contributor Author

cluster propagation policy and failover e2e test coverage may need enhancement, can u help me confirm that and create the issue @XiShanYongYe-Chang , there are some TODO in that analysis files

@XiShanYongYe-Chang
Copy link
Member

cluster propagation policy and failover e2e test coverage may need enhancement, can u help me confirm that and create the issue @XiShanYongYe-Chang , there are some TODO in that analysis files

Of course, how can I help you? Create an issue?

@Vacant2333
Copy link
Contributor Author

cluster propagation policy and failover e2e test coverage may need enhancement, can u help me confirm that and create the issue @XiShanYongYe-Chang , there are some TODO in that analysis files

Of course, how can I help you? Create an issue?

yes, and those TODO may not correct, im cant confirm that , may u can confirm those

@XiShanYongYe-Chang
Copy link
Member

yes, and those TODO may not correct, im cant confirm that , may u can confirm those

Ok, I will do it later~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@jwcesign jwcesign Awaiting requested review from jwcesign

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vacant2333 @codecov-commenter @XiShanYongYe-Chang @jwcesign @karmada-bot