Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add e2e coverage detail #4436

Merged
merged 1 commit into from
Dec 25, 2023
Merged

docs: add e2e coverage detail #4436

merged 1 commit into from
Dec 25, 2023

Conversation

Vacant2333
Copy link
Contributor

What type of PR is this?
/kind documentation
add more e2e cocverage detail

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #3685

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 15, 2023
@Vacant2333 Vacant2333 changed the title add e2e coverage detail docs: add e2e coverage detail Dec 15, 2023
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Dec 15, 2023
@Vacant2333 Vacant2333 marked this pull request as draft December 16, 2023 12:15
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2023
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Dec 17, 2023
@Vacant2333 Vacant2333 marked this pull request as ready for review December 18, 2023 15:38
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2023
@XiShanYongYe-Chang
Copy link
Member

Hi @Vacant2333, dose it is ready for review?

@XiShanYongYe-Chang
Copy link
Member

/assign

@Vacant2333
Copy link
Contributor Author

Hi @Vacant2333, dose it is ready for review?

yes

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

test/e2e/coverage_docs/federatedresourcequota_test.md Outdated Show resolved Hide resolved
add e2e coverage detail
60b2e4a 
Signed-off-by: Vacant <vacant@MasterNode.local>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bebd4c) 51.88% compared to head (60b2e4a) 51.88%.
Report is 64 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4436   +/-   ##
=======================================
  Coverage   51.88%   51.88%           
=======================================
  Files         243      243           
  Lines       24114    24177   +63     
=======================================
+ Hits        12511    12545   +34     
- Misses      10921    10951   +30     
+ Partials      682      681    -1
Flag Coverage Δ
unittests 51.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 25, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 25, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2023
@karmada-bot karmada-bot merged commit 2a2db3f into karmada-io:master Dec 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@Poor12 Poor12 Awaiting requested review from Poor12

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vacant2333 @XiShanYongYe-Chang @codecov-commenter @karmada-bot