[1.9] chore: skip push event for branches of dependabot. #4976

liangyuanpeng · 2024-05-23T07:04:09Z

What type of PR is this?

/kind cleanup
What this PR does / why we need it:

cherry pick #4762 to release-1.9, after #4932, dependabot will create PR for release branchs, and we need to skip some push event for dependabot.

releated:

Bump alpine from 3.19.1 to 3.20.0 in /cluster/images #4971

/assign @RainbowMango

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

RainbowMango

/lgtm
/approve

Just reminder, you can use hack/cherry_pick_pull.sh to do this work, probably easier.

karmada-bot · 2024-05-23T07:07:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RainbowMango · 2024-05-23T07:16:27Z

The test seems unrelated:

I0523 07:13:57.402043   29341 check.go:42] Waiting for APIService(v1alpha1.cluster.karmada.io) condition(Available), will try
I0523 07:13:58.402499   29341 check.go:42] Waiting for APIService(v1alpha1.cluster.karmada.io) condition(Available), will try
I0523 07:13:58.404562   29341 check.go:42] Waiting for APIService(v1alpha1.cluster.karmada.io) condition(Available), will try
F0523 07:13:58.404578   29341 deploy.go:121] timed out waiting for the condition

/retest

liangyuanpeng · 2024-05-23T07:19:16Z

use hack/cherry_pick_pull.sh to do this work, probably easier.

Yes, i run this scripts first and it's failed, have not see any conflict, so i skip cherry pick with the scripts.

...
Applying: chore: skip push event for branches of dependabot.
Using index info to reconstruct a base tree...
M       .github/workflows/ci.yml
M       .github/workflows/cli.yaml
error: patch failed: .github/workflows/ci-image-scanning.yaml:1
error: .github/workflows/ci-image-scanning.yaml: patch does not apply
error: Did you hand edit your patch?
...

liangyuanpeng · 2024-05-23T08:10:27Z

Tested on kubernetes 1.29 and karmada-aggregated-apiserver have some error about APIPriorityAndFairness

Error: invalid argument "APIPriorityAndFairness=false" for "--feature-gates" flag: cannot set feature gate APIPriorityAndFairness to false, feature is locked to true

liangyuanpeng · 2024-05-23T08:20:42Z

try again
/retest

liangyuanpeng · 2024-05-23T08:45:12Z

seems like karmada-aggregated-apiserver is using the latest image and not the local build image from release-1.9

...
Image: "docker.io/karmada/karmada-aggregated-apiserver:latest" with ID "sha256:c520dd5ad28b2c00e23a2864b5491d6a242ed70f5cc0e56282b16f4265fa6a2e" not yet present on node "karmada-host-control-plane", loading...
Start init karmada control plane...
...

$ docker exec karmada-host-control-plane crictl images --digests
IMAGE                                            TAG                  DIGEST              IMAGE ID            SIZE
docker.io/karmada/karmada-aggregated-apiserver   latest               91dfe34aa3cef       41ae560c9c94d       43MB
docker.io/library/import-2024-05-23              <none>               7ff1525d0a91a       c520dd5ad28b2       101MB

docker.io/karmada/karmada-aggregated-apiserver:latest (91dfe34aa3cef ) is the latest image and docker.io/library/import-2024-05-23(7ff1525d0a91a) is the local build image from release-1.9, have not find the reason for what happen. (why only happing on release-1.9 )

liangyuanpeng · 2024-05-23T09:00:47Z

it's successed when i add ImagePullPolicy PullIfNotPresent for karmada-aggregated-apiserver

		Containers: []corev1.Container{
			{
				Name:            karmadaAggregatedAPIServerDeploymentAndServiceName,
				Image:           i.karmadaAggregatedAPIServerImage(),
				Command:         command,
				ImagePullPolicy: corev1.PullIfNotPresent,
...

RainbowMango · 2024-05-23T11:53:01Z

seems like karmada-aggregated-apiserver is using the latest image and not the local build image from release-1.9

Oh? I'm afraid there is something wrong.

it's successed when i add ImagePullPolicy PullIfNotPresent for karmada-aggregated-apiserver

Can you explain it a little bit? I don't get how this fixed the previous problem.

zhzhuang-zju · 2024-05-27T03:00:43Z

Can you explain it a little bit? I don't get how this fixed the previous problem.

This is actually two questions:

why karmada-aggregated-apiserver is using the latest image
Refer to

karmada/hack/cli-testing-environment.sh

Lines 43 to 46 in b57bff1

    
           # make images 
        
           export VERSION="latest" 
        
           export REGISTRY="docker.io/karmada" 
        
           make images GOOS="linux" --directory="${REPO_ROOT}"

karmada/hack/cli-testing-environment.sh

Lines 82 to 89 in b57bff1

    
           ${BUILD_PATH}/karmadactl init --kubeconfig=${KUBECONFIG_PATH}/${HOST_CLUSTER_NAME}.config \ 
        
               --karmada-controller-manager-image="${REGISTRY}/karmada-controller-manager:${VERSION}" \ 
        
               --karmada-scheduler-image="${REGISTRY}/karmada-scheduler:${VERSION}" \ 
        
               --karmada-webhook-image="${REGISTRY}/karmada-webhook:${VERSION}" \ 
        
               --karmada-aggregated-apiserver-image="${REGISTRY}/karmada-aggregated-apiserver:${VERSION}" \ 
        
               --karmada-data=${HOME}/karmada \ 
        
               --karmada-pki=${HOME}/karmada/pki \ 
        
               --crds=./crds.tar.gz

and

karmada/pkg/karmadactl/cmdinit/cmdinit.go

Line 162 in b57bff1

    
           flags.StringVarP(&opts.KarmadaAggregatedAPIServerImage, "karmada-aggregated-apiserver-image", "", kubernetes.DefaultKarmadaAggregatedAPIServerImage, "Karmada aggregated apiserver image")

,
the value of KarmadaAggregatedAPIServerImage will be docker.io/karmada/karmada-aggregated-apiserver:latest.
Refer to

karmada/pkg/karmadactl/cmdinit/kubernetes/deploy.go

Line 121 in b57bff1

    
           DefaultKarmadaAggregatedAPIServerImage = fmt.Sprintf("docker.io/karmada/karmada-aggregated-apiserver:%s", releaseVer.ReleaseVersion())

and

karmada/pkg/karmadactl/cmdinit/kubernetes/deploy.go

Lines 705 to 709 in b57bff1

    
           func (i *CommandInitOption) karmadaAggregatedAPIServerImage() string { 
        
           	if i.ImageRegistry != "" && i.KarmadaAggregatedAPIServerImage == DefaultKarmadaAggregatedAPIServerImage { 
        
           		return i.ImageRegistry + "/karmada-aggregated-apiserver:" + karmadaRelease 
        
           	} 
        
           	return i.KarmadaAggregatedAPIServerImage

,
since i.KarmadaAggregatedAPIServerImage != DefaultKarmadaAggregatedAPIServerImage, the imageRef of karmada-aggregated-apiserver will be docker.io/karmada/karmada-aggregated-apiserver:latest, rather than docker.io/karmada/karmada-aggregated-apiserver:release-1.9.
When the tag of image is latest, ImagePullPolicy will be default to always, that means Kubernetes will always pull the latest version of the image from the container registry. So the e2e environment doesn't actually use the locally built image.

why adding ImagePullPolicy IfNotPresent for karmada-aggregated-apiserver works?
when the ImagePullPolicy of karmada-aggregated-apiserver is IfNotPresent, the e2e environment will use the local image built from release-1.9 branch code.

Besides, we should add imagePullPolicy IfNotPresent for all karmada components, not just component karmada-aggregated-apiserver. They both have the same problem, except that the component "karmada-agregated-apiserver" was exposed due to a breaking change.

Refer to #4815, changes have been made in the master branch, we just need to cherry-pick them to release-1.9.
cc @RainbowMango @liangyuanpeng

liangyuanpeng · 2024-05-27T03:11:38Z

Thanks for your time, i have not into it again yet, actually i believe that i advocated not using the latest image tag, but i have not found the history.I think a better approach is to update the tags used by the test image rather than backport a new features. WDYT?

like use tag of test or e2etest and not latest.
@zhzhuang-zju

RainbowMango · 2024-05-27T03:29:01Z

Given that we will fix the CI issue on the release branch, I am supposed to fix it the way we did on the master branch.

That is backporting the #4815 to release-1.9. But as @liangyuanpeng mentioned, we usually don't backport features onto release branches, so, I think we can backport part of #4815, just change the default ImagePullPolicy to PullIfNotPresent(not bring the new flag --image-pull-policy) for all of the components not only the karmada-aggregate-apiserver.

zhzhuang-zju · 2024-05-27T03:36:02Z

I think we can backport part of #4815, just change the default ImagePullPolicy to PullIfNotPresent(not bring the new flag --image-pull-policy) for all of the components not only the karmada-aggregate-apiserver.

get it

RainbowMango · 2024-05-27T06:23:10Z

Hi @liangyuanpeng, you can rebase this PR now.

Co-authored-by: zhzhuang-zju <m17799853869@163.com> Co-authored-by: RainbowMango <qdurenhongcai@gmail.com> Signed-off-by: Lan Liang <gcslyp@gmail.com>

RainbowMango · 2024-05-27T06:59:32Z

/lgtm

karmada-bot assigned RainbowMango May 23, 2024

karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 23, 2024

karmada-bot requested review from chaosi-zju and jwcesign May 23, 2024 07:04

liangyuanpeng changed the title ~~chore: skip push event for branches of dependabot.~~ [1.9] chore: skip push event for branches of dependabot. May 23, 2024

karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2024

RainbowMango approved these changes May 23, 2024

View reviewed changes

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2024

RainbowMango mentioned this pull request May 27, 2024

[1.9] karmadactl init: set default value of imagePullPolicy to IfNotPresent #4988

Merged

chore: skip push event for branches of dependabot.

021f00b

Co-authored-by: zhzhuang-zju <m17799853869@163.com> Co-authored-by: RainbowMango <qdurenhongcai@gmail.com> Signed-off-by: Lan Liang <gcslyp@gmail.com>

liangyuanpeng force-pushed the cherrypick_1.9_4762 branch from 44d61a2 to 021f00b Compare May 27, 2024 06:38

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024

karmada-bot merged commit 93a403a into karmada-io:release-1.9 May 27, 2024
12 checks passed

pulsarsigs-bot deleted the cherrypick_1.9_4762 branch May 27, 2024 07:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1.9] chore: skip push event for branches of dependabot. #4976

[1.9] chore: skip push event for branches of dependabot. #4976

liangyuanpeng commented May 23, 2024

RainbowMango left a comment

karmada-bot commented May 23, 2024

RainbowMango commented May 23, 2024

liangyuanpeng commented May 23, 2024

liangyuanpeng commented May 23, 2024

liangyuanpeng commented May 23, 2024

liangyuanpeng commented May 23, 2024 •

edited

Loading

liangyuanpeng commented May 23, 2024 •

edited

Loading

RainbowMango commented May 23, 2024

zhzhuang-zju commented May 27, 2024

liangyuanpeng commented May 27, 2024 •

edited

Loading

RainbowMango commented May 27, 2024

zhzhuang-zju commented May 27, 2024

RainbowMango commented May 27, 2024

RainbowMango commented May 27, 2024

[1.9] chore: skip push event for branches of dependabot. #4976

[1.9] chore: skip push event for branches of dependabot. #4976

Conversation

liangyuanpeng commented May 23, 2024

RainbowMango left a comment

Choose a reason for hiding this comment

karmada-bot commented May 23, 2024

RainbowMango commented May 23, 2024

liangyuanpeng commented May 23, 2024

liangyuanpeng commented May 23, 2024

liangyuanpeng commented May 23, 2024

liangyuanpeng commented May 23, 2024 • edited Loading

liangyuanpeng commented May 23, 2024 • edited Loading

RainbowMango commented May 23, 2024

zhzhuang-zju commented May 27, 2024

liangyuanpeng commented May 27, 2024 • edited Loading

RainbowMango commented May 27, 2024

zhzhuang-zju commented May 27, 2024

RainbowMango commented May 27, 2024

RainbowMango commented May 27, 2024

liangyuanpeng commented May 23, 2024 •

edited

Loading

liangyuanpeng commented May 23, 2024 •

edited

Loading

liangyuanpeng commented May 27, 2024 •

edited

Loading