-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding FlinkDeployment CRD to supported third party resource customizations #5023
Conversation
/assign @yike21 @chaunceyjiang |
@mszacillo Thanks for your contribution! |
/assign |
...irdparty/resourcecustomizations/flink.apache.org/v1beta1/FlinkDeployment/customizations.yaml
Outdated
Show resolved
Hide resolved
…ations Signed-off-by: mszacillo <mszacillo@bloomberg.net>
89a5e4f
to
f822072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
...irdparty/resourcecustomizations/flink.apache.org/v1beta1/FlinkDeployment/customizations.yaml
Outdated
Show resolved
Hide resolved
...irdparty/resourcecustomizations/flink.apache.org/v1beta1/FlinkDeployment/customizations.yaml
Show resolved
Hide resolved
...irdparty/resourcecustomizations/flink.apache.org/v1beta1/FlinkDeployment/customizations.yaml
Outdated
Show resolved
Hide resolved
…preter, adding getResourceQuantity function to kube library Signed-off-by: mszacillo <mszacillo@bloomberg.net>
Signed-off-by: mszacillo <mszacillo@bloomberg.net>
5931b52
to
a1bcbf1
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5023 +/- ##
===========================================
- Coverage 53.30% 28.20% -25.11%
===========================================
Files 253 632 +379
Lines 20560 43571 +23011
===========================================
+ Hits 10960 12288 +1328
- Misses 8874 30385 +21511
- Partials 726 898 +172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...irdparty/resourcecustomizations/flink.apache.org/v1beta1/FlinkDeployment/customizations.yaml
Show resolved
Hide resolved
Signed-off-by: mszacillo <mszacillo@bloomberg.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@bharathguvvala Do you have any further comments?
LGTM for me as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a default resource customization for FlinkDeployments. Below is a summary of the supported default interpretations:
Supported
InterpretHealth
spec.status.jobStatus.state
. FlinkDeployments can enter errored states due to user related code issues, rather than due to bad cluster health or lack of cluster resources. As a result we want to differentiate from these cases so that Karmada only reschedules these apps when needed.Unhealthy
only if the internal flink state is trapped in a non-terminal state - these states include:InterpretReplica
InterpretStatus
AggregateStatus
Not Supported
Retention
ReplicaRevision
InterpretDependency
Which issue(s) this PR fixes:
Fixes #4953
Testing
Tested on cluster and confirmed default interpreters work with FlinkDeployment.
Does this PR introduce a user-facing change?: