Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs userguide #162

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Add docs userguide #162

merged 4 commits into from
Sep 23, 2022

Conversation

justedennnnn
Copy link
Contributor

What type of PR is this?

/kind documentation

-->

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 7, 2022
@karmada-bot
Copy link
Collaborator

Welcome @justedennnnn! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2022
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justedennnnn 十分感谢你提交了对MCS的使用提交了中文翻译。

整体感觉翻译有点直接，可以适当的修改为更方便阅读并理解的中文语句，再次表示感谢~~

i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated Show resolved Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated Show resolved Hide resolved
@justedennnnn
Copy link
Contributor Author

感谢您的建议，已修正。

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Sep 8, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多谢你的快速响应，你可以参考 https://github.com/karmada-io/website/pull/162/checks?check_run_id=8227486090 来修改你的签名。

i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated
@@ -2,26 +2,27 @@
title: Multi-cluster Service Discovery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思，我上次可能没解释好，改成这样可以么：

title: 多集群服务发现

i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated
After ServiceExport and ServiceImport have been installed on the **karmada control-plane**, we can create `ClusterPropagationPolicy` to propagate those two CRDs to the member clusters.
我们需要在成员集群中安装ServiceExport和ServiceImport。

在在**karmada控制平面**上安装完 ServiceExport 和 ServiceImport 之后，我们可以创建 `ClusterPropagationPolicy` 来传播这两个 CRD 到成员集群。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开头多了一个“在”字。
”传播“可以修改为”分发“么？

i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated
@@ -56,11 +57,11 @@ spec:
- member1
- member2
```
## Example
## 例如
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改为”示例“可能会比较好。

i18n/zh/docusaurus-plugin-content-docs/current/userguide/service/multi-cluster-service.md Outdated

Start a Pod `request` on the `member2` cluster to access the ClusterIP of **derived service**:
在 `member2` 集群上启动一个Pod `request`来访问**衍生服务**的ClusterIP。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

”衍生服务“可否修改为”派生服务“呢？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改不及时，不好意思。感谢指导，已修改。

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多谢修改
LGTM
/cc @Poor12

@Poor12
Copy link
Member

Poor12 commented Sep 23, 2022

Thanks~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
RainbowMango
RainbowMango approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@karmada-bot karmada-bot merged commit 342dc06 into karmada-io:main Sep 23, 2022
@justedennnnn justedennnnn mentioned this pull request Jul 12, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@pigletfly pigletfly Awaiting requested review from pigletfly

@rgrupesh rgrupesh Awaiting requested review from rgrupesh

@Poor12 Poor12 Awaiting requested review from Poor12

Assignees

@Poor12 Poor12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justedennnnn @karmada-bot @Poor12 @RainbowMango @XiShanYongYe-Chang