Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add favicons #23

Merged
merged 1 commit into from
Mar 28, 2022
Merged

add favicons #23

merged 1 commit into from
Mar 28, 2022

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Mar 21, 2022

resolve #22

@karmada-bot
Copy link
Collaborator

@Arhell: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2022
@Arhell
Copy link
Member Author

Arhell commented Mar 21, 2022

https://realfavicongenerator.net/favicon_checker?protocol=https&site=deploy-preview-23--karmada.netlify.app%2F#.YjhIf-rP23A

@Arhell Arhell force-pushed the favicon branch 3 times, most recently from 38733be to 65991a8 Compare March 21, 2022 22:33
@Arhell Arhell marked this pull request as ready for review March 21, 2022 22:34
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2022
@Arhell
Copy link
Member Author

Arhell commented Mar 21, 2022

/assign @RainbowMango

@RainbowMango RainbowMango removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 22, 2022
@RainbowMango
Copy link
Member

cc @rgrupesh
Can you help to take a look?

@rgrupesh
Copy link
Member

LGTM! @RainbowMango

@Arhell One feedback: always make the issue thorough. Add the details in the issue itself. I mean which specific icons are added or to be added and such. The link was helpful though. It would help to review effectively.

@Arhell
add favicons
1e826ac 
Signed-off-by: Arhell <arhell333@gmail.com>
RainbowMango
RainbowMango approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit c60b5cc into karmada-io:main Mar 28, 2022
@Arhell Arhell deleted the favicon branch March 28, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add favicons
4 participants
@Arhell @karmada-bot @RainbowMango @rgrupesh