Add custom metrics for FederatedHPA #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
do-not-merge/work-in-progress
karmada-bot
added
the
size/XL
Poor12
force-pushed
the
add-custom-metrics
branch
from
5190d63
to
c44bb2a
Compare
karmada-bot
removed
the
do-not-merge/work-in-progress
windsonsea
reviewed
Jul 3, 2023
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-custom-metrics.md
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-custom-metrics.md
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/autoscaling-with-custom-metrics.md
Outdated
Show resolved
Hide resolved
Poor12
force-pushed
the
add-custom-metrics
branch
3 times, most recently
from
0659321
to
1cd1a26
Compare
jwcesign
reviewed
Jul 28, 2023
Comment on lines
+80
to
+83
| git clone https://github.com/prometheus-operator/kube-prometheus.git | ||
| cd kube-prometheus | ||
| kubectl apply --server-side -f manifests/setup | ||
| kubectl wait \ |
There was a problem hiding this comment.
Can we use one specific version?
There was a problem hiding this comment.
I think using the main branch is ok.
| @@ -35,3 +35,4 @@ If you configure FederatedHPA, you may also want to consider running a cluster-l | |||
|
|
|||
| For more information on FederatedHPA: | |||
| * Read a [FederatedHPA tutorials](../../tutorials/autoscaling-with-federatedhpa.md) for FederatedHPA. | |||
There was a problem hiding this comment.
How about renaming this to FederatedHPA tutorials with CPU/Memory utilization metrics?
There was a problem hiding this comment.
Sorry, I mean changing line 37 to this.
Signed-off-by: Poor12 <shentiecheng@huawei.com>
Poor12
force-pushed
the
add-custom-metrics
branch
from
1cd1a26
to
ce6e308
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add custom metrics for FederatedHPA
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
None