Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend caching options in controller #204

Merged
merged 11 commits into from
Mar 22, 2024

Conversation

ratzrattillo
Copy link
Contributor

Allow setting force_cache in controller
Allow custom hooks to determine cachable requests/responses

Allow setting force_cache in controller
Allow custom hooks to determine cachable requests/responses
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5075342) to head (102eff1).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #204    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           29        29            
  Lines         2115      2614   +499     
==========================================
+ Hits          2115      2614   +499     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karpetrosyan
Copy link
Owner

Great job, thanks!
Can we add only force_cache for this PR?
I think it would be much neater to have a separate PR for the hooks + we should first understand where we want to put that logic.

@karpetrosyan karpetrosyan added the enhancement New feature or request label Mar 21, 2024
@karpetrosyan karpetrosyan merged commit 319635a into karpetrosyan:master Mar 22, 2024
8 checks passed
@karpetrosyan karpetrosyan mentioned this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants