Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug where package.weight.map(MeasurementOptions).KG would round down to 0 when making a conversion to kg failing canadapost rate request #204

Closed
HansDaigle opened this issue May 24, 2022 · 1 comment · Fixed by #200

Comments

@HansDaigle
Copy link

Describe the bug
Bug where package.weight.map(MeasurementOptions).KG would round down to 0 when making a conversion to kg failing Canada post rate request

To Reproduce
Steps to reproduce the behavior:

Make a Canada post rate request with a smaller weight than 0.1 kg.

fix

Change providers.canadapost.units:

MeasurementOptions = MeasurementOptionsType(quant=0.01, min_kg=0.01)

I have a fix on a branch but I'm not allowed to make de pull request.

@danh91
Copy link
Member

danh91 commented May 25, 2022

Hi @HansDaigle,

Thank you for reporting this.
I was able to reproduce it.
The fix will be added to the upcoming release 2022.1.4

0d15757

@danh91 danh91 linked a pull request May 25, 2022 that will close this issue
@danh91 danh91 removed this from the Karrio 2022.4 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants