Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close add-new-entry form when clicking on existing entry #158

Closed
1 of 2 tasks
wellemut opened this issue Mar 25, 2023 · 2 comments · Fixed by #170
Closed
1 of 2 tasks

close add-new-entry form when clicking on existing entry #158

wellemut opened this issue Mar 25, 2023 · 2 comments · Fixed by #170
Assignees
Labels
01 refactoring not a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/ storypoint:2

Comments

@wellemut
Copy link
Member

wellemut commented Mar 25, 2023

User Story: As a new mapper I want to open an existing entry on the map to check, if its really a duplicate, without having to find the "back" button from the entry formular or closing it manually. Because finding the button is too complicated for first time mappers and takes to long for experienced mappers. And when I close the entry-form, but a filter is activated, I might loose the duplicate entry, unable to find it again. (And if the user would find out how to remove the filter, he might forget to add the corresponding tag again)

Problem

Solution

Improvement (optional, next sprint)

  • show a warning before closing, if the user has already changed or added things in the form

Similar: #103

@wellemut wellemut changed the title close add-new-entry-form when clicking on existing every close add-new-entry form when clicking on existing entry Mar 25, 2023
@wellemut wellemut added the 01 refactoring not a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/ label Mar 25, 2023
@wellemut wellemut added this to the 2023-04 finalizing Refactoring milestone Mar 27, 2023
@wellemut wellemut modified the milestones: 2023-04 finalizing Refactoring, 2023-04- 12.-26. Refactoring-Sprint Apr 19, 2023
@navid-kalaei navid-kalaei self-assigned this Apr 23, 2023
navid-kalaei added a commit that referenced this issue Apr 24, 2023
feat(#158): make other markers clickable on the creating and editing …
@wellemut
Copy link
Member Author

wellemut commented Apr 25, 2023

Its working great on https://dev.kartevonmorgen.org/m/main/ev/35caff320bf74422966c301e81cdca5c/edit?c=64.6427%2C24.4556&z=3.00&search=ex+esd-expertnet

😢 minor Bug: When you click on an event, the event-edit form gets loaded, but without loading the event time...
grafik

But still we should push that update to productive.

Its a different user Flow after refactoring:
in the old version https://v0.kartevonmorgen.org/#/?center=51.000,10.223&search=%23water&addentry=initiative&dropdowns=kvm it was different

  1. When opening the "add entry formular", every entry (even those outside the active filter) become visible ✔️
  2. You can click on every entry to open it ✔️
  3. The entry will open as normal view (not in the opened formular) ❌
  4. User has to click "edit" if he wants to edit the seltected entry
  5. The active filter-tags will be directly added to the form, while the edit-form is opening ✔️

In the new frontend https://dev.kartevonmorgen.org/m/main/e/create?c=55.9123%2C15.7324&z=5.00&tag=esd-expertnet step 3 and 4 are skipped. Which is an intresting change which we will observe, how user behave with it. Save enough to try, good enough for now!

😢 Step 5 is not working for events

All Bugs or Problems are without problem.

navid-kalaei added a commit that referenced this issue Apr 25, 2023
feat(#158): update the tags, start and the end time in the events on edit
navid-kalaei added a commit that referenced this issue Apr 26, 2023
feat(#158): do not add many tags on editing entries
@wellemut
Copy link
Member Author

navid-kalaei added a commit that referenced this issue Apr 26, 2023
feat(#158): do not add many tags on editing events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 refactoring not a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/ storypoint:2
Projects
None yet
2 participants