Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom preview arrows orientation for RTL #987

Closed
wants to merge 1 commit into from

Conversation

sepehrr
Copy link

@sepehrr sepehrr commented May 30, 2017

Scope

This pull request includes a

  • Bug fix

Related Issues

fixed arrows problem on rtl

@kartik-v
Copy link
Owner

kartik-v commented May 30, 2017

No ... do not change the CSS for this - because this may not work correctly if user sets one's own icons which will not have a proper mirror image.

Refer the demo usage example for RTL orientation.

@kartik-v kartik-v closed this May 30, 2017
@kartik-v
Copy link
Owner

Actually do not worry... I will provide an enhancement to automate this.

@kartik-v kartik-v reopened this May 30, 2017
@kartik-v kartik-v changed the title fixed arrows problem on rtl Zoom preview arrows orientation for RTL May 30, 2017
@kartik-v kartik-v closed this in cdb260b May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants