Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module handling seems wrong #215

Closed
ittayd opened this issue Aug 2, 2021 · 2 comments
Closed

Module handling seems wrong #215

ittayd opened this issue Aug 2, 2021 · 2 comments

Comments

@ittayd
Copy link

ittayd commented Aug 2, 2021

The module wrapping checks if module.exports is defined and if so assigns to it the result of the factory function. But this function doesn't have a return value, so module.exports ends up being undefined.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ittayd
Copy link
Author

ittayd commented Aug 2, 2021

Also, themes ignore any module system and use window.jQuery directly.

@kartik-v
Copy link
Owner

kartik-v commented Aug 3, 2021

Thanks. Will check when I get time. Appreciate if you can submit a PR enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants