Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated value of empty star in the Font Awesome theme for the (new) Font Awesome version (5.x) #182

Closed
wants to merge 2 commits into from

Conversation

Hannoma
Copy link

@Hannoma Hannoma commented Mar 26, 2018

Scope

This pull request includes a

  • Bug fix
  • New feature
  • Translation

Changes

The following changes were made

  • Changed value for empty star from "fa fa-star-o" to "far fa-star"

Related Issues

#181

@kartik-v
Copy link
Owner

kartik-v commented Mar 27, 2018

Not the correct way to do this - need to create a separate theme for Font Awesome 5 as mentioned in the #181 comment.

@kartik-v kartik-v closed this Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants