-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite dhow
#13
base: master
Are you sure you want to change the base?
Rewrite dhow
#13
Conversation
Pull from upstream
Potentially breaking change in the current code, Also introduced --input and --output to replace --indir and --outdir mostly because I really didn't want to write I also implemented a logger since I don't like spinners. Feel free to revert that, I don't mind. Reminds me of Next.js though, which is usually not a bad thing. Did some testing in regards to the in-memory builds, I think they will work but I don't have the time at the moment. |
Scratch --input and --output, not worth making this refactor breaking. I wouldn't consider |
Tried running a few of the examples & committed a few bug fixes. I'm unable to debug the |
Where did you commit those bug fixes to? Also I should note that I have a lot of uncommitted changes right now, I anticipate a big commit in the next couple of days. This should include incremental builds and caching in the build function for |
Also, in regards to in-memory builds: they seem largely impossible at the moment (without requiring our users to opt into experimental NodeJS modules and forcing .mjs) so I've stopped pursuing them. If you want to give it a shot let me know and I'll post more info. |
This is a big one. I almost regret splitting I'm doing all this because I use tailwind, and I got tired of waiting for >10s every build just because PostCSS is slow, even though I didn't even touch a |
Also remove an obnoxious debug log
Add a DOCTYPE to make it a valid HTML5 Document
Update Readme to make it less personal
Closes #12
Closes #9
Also related to #11
Stuff that's still TODO:
fully implement CLI (I'd like to propose some breaking changes in this regard though, but that's best discussed in the original issue)related to the above: don't expect the input directory to contain a pages directory, expect the input directory to be the pages directorybuild fully in-memory (although it might be a good idea to have that be a separate PR, to be worked on once this is landed)doesn't look like this is feasible at the moment