use django as proxy for every OGC requests #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
commented
Jun 2, 2017
geonode/qgis_server/views.py
Outdated
| if not params.get('LAYERS'): | ||
| raise Http404('LAYERS is not found for a GetLegendGraphic') | ||
| layer = get_object_or_404(Layer, typename=params.get('LAYER')) | ||
| return legend(request, layername=layer.name) |
There was a problem hiding this comment.
@lucernae As we removing the legend, how can I get the legend path?
If not easy, I can forward the request to QGIS Server.
|
@gubuntu this PR brings the OGC proxy for QGIS-Server |
Codecov Report
@@ Coverage Diff @@
## master-qgis_server #237 +/- ##
======================================================
+ Coverage 44.1% 44.28% +0.18%
======================================================
Files 254 254
Lines 18383 18292 -91
Branches 2417 2409 -8
======================================================
- Hits 8107 8100 -7
+ Misses 9803 9719 -84
Partials 473 473
Continue to review full report at Codecov.
|
|
I think I can merge even if codecov/patch is not fully happy. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use django as proxy for every OGC requests
@ismailsunni Is-it ok to remove all these specifics views in the app and just one view to forward the request to QGIS
I would like of course to add some unittest, but I need first some qgis layers in the test DB. @lucernae did you work on that before ?