Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images: support multiple texture atlases; use common bind group #187

Merged
merged 6 commits into from
Apr 20, 2021
Merged

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Apr 20, 2021

Image atlases are now created on demand, thus no atlases if no images are used, and new ones allocated as necessary to hold loaded images.

Limitations:

  • images are currently only freed if manually cleared (I will create a new issue for garbage collection)
  • atlases are never freed
  • multiple uses of the same path are not deduplicated
  • images too big to fit in an atlas are not handled (ImageError::Allocation)
  • images are loaded immediately on request, where they could be background loaded

@dhardy dhardy merged commit e4ad6b4 into master Apr 20, 2021
@dhardy dhardy mentioned this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant