Apply draw offset in vertex shaders; data-list reverse button, editbox scrolling #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clip-region offsets are now applied by the vertex shaders, thus:
DrawHandle::draw_device
no longer returns anOffset
which needs to be applied in user and theme code.bg_common
bind group contains scale and offset data and must be updated for each clip region. This is a fairly small extra cost, and might instead use push-constants later. This change will be helpful if we decide to add indirect rendering to textures in the future.ListView
.Additionally,
ScrollLabel
for the multi-lingual text label, enabling selectionEditField
now updates itsrequired
field on text edits, thus fixing scrolling of contentsdata-list
anddata-list-view
examples have reverse-direction buttons (with fixes for reversedListView
)Directional::Reversed
type andreversed
method