ScrollText widget, font sizes in pixels, AdaptWidget::on_messages, misc fixes #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, ScrollText works very well, I even understood how you fused Text and ScrollLabel by looking at this code but it involves a crazy amount of copy-pasting, can you use some of your macro magic to make a more composable widget system ? |
|
Something to think about for sure. But pushing more complexity into macros isn't necessarily a good answer; you already accused my macros of being black magic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notable is probably the
ScrollTextwidget, requested in #415 (CC @m-hugo). Not currently used.Font sizes probably shouldn't use old imperial units intended for publishing on paper (even if Windows and many Linux DEs still do).