Massive extension of list of enabled CSS properties and values. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Massively extended list of nowadays common and technically supported but previously disabled CSS property names.
Added support for common "display" values related to flex and grid layouts.
Extended list of enabled "display" values related to flex and grid layouts.
|
I have since tested it and Odyssey 1.23 has "grid layout" disabled by
default.
There are significant related code portions missing compared to Odyssey
1.24 and later. I remember you made public statements in the past
suggesting the Webkit version in Odyssey 1.24 would be an insignificant
upgrade due to the small difference in age but "grid support" should not
be underestimated.
If you have time to experiment with this, you might want to compile with
these options (or variations thereof):
set(ENABLE_CSS_GRID_LAYOUT ON)
Also, as an extra:
set(ENABLE_CSS_SHAPES ON)
That being said, even with grid support disabled, the CSS patches should
still have significant effects. Websites like "google.com" (text in
input field) or "allegro.pl" should look notably different due to their
specific use of flexbox layouts.
Best regards,
André
|
|
Hi, trying to build (crosscompile) I get this error: |
|
As a quick fix, I would recommend to revert this specific file to its prior state but leave the other two updated files as-is.
Fortunately, leaving out this file should not have too much of an effect in any case.
… On 8. Jun 2022, at 10:42, Javier de las Rivas ***@***.***> wrote:
Hi, trying to build (crosscompile) I get this error:
...
In file included from /home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSBasicShapes.cpp:34:
/home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSPrimitiveValueMappings.h: In constructor ‘WebCore::CSSPrimitiveValue::CSSPrimitiveValue(T) [with T = WebCore::EDisplay]’:
/home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSPrimitiveValueMappings.h:1347:10: error: ‘WEBKIT_FLEX’ was not declared in this scope; did you mean ‘WEBKIT_LEFT’?
1347 | case WEBKIT_FLEX: // andresiegel
| ^~~~~~~~~~~
| WEBKIT_LEFT
...
#31 <#31>
—
Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD77KKML6G2GQTK4K6RKOBLVOBMHTANCNFSM5PXIA46Q>.
You are receiving this because you authored the thread.
|
|
THX, will do it ASAP an post here result, BTW I added those "new" options into "main" CMakeLists.txt: Is it ok? Will see what I get. |
|
It’s certainly worth giving this a try but there are strong indications that “grid” support may be largely unfinished in the Webkit version used by Odyssey v1.23.
… On 8. Jun 2022, at 12:43, Javier de las Rivas ***@***.***> wrote:
THX, will do it ASAP an post here result, BTW I added those "new" options into "main" CMakeLists.txt:
set(ENABLE_CSS_GRID_LAYOUT ON)
set(ENABLE_CSS_SHAPES ON)
Is it ok? Will see what I get.
—
Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD77KKJKBJ6LNZJUWQWDPNLVOB2O5ANCNFSM5PXIA46Q>.
You are receiving this because you authored the thread.
|
|
Yes, you're right I get some GRID errors :-/ so can't build Oddysey. |
|
In order to fix the problem, try to undo your cmake.txt changes.
… On 10. Jun 2022, at 09:21, Javier de las Rivas ***@***.***> wrote:
Yes, you're right I get some GRID errors :-/ so can't build Oddysey.
I imagine to "fix" this problem Odyssey should be updated first to 1.24 code?
—
Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD77KKPHPR3JKYEFS5ZDRRDVOLUHVANCNFSM5PXIA46Q>.
You are receiving this because you authored the thread.
|
I committed some minor changes. Odyssey v1.23 fully compiles for me. |
|
Put differently, remove this…
set(ENABLE_CSS_GRID_LAYOUT ON)
set(ENABLE_CSS_SHAPES ON)
And see what happens.
… On 10. Jun 2022, at 10:31, André Siegel ***@***.***> wrote:
In order to fix the problem, try to undo your cmake.txt changes.
> On 10. Jun 2022, at 09:21, Javier de las Rivas ***@***.*** ***@***.***>> wrote:
>
>
> Yes, you're right I get some GRID errors :-/ so can't build Oddysey.
> I imagine to "fix" this problem Odyssey should be updated first to 1.24 code?
>
> —
> Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD77KKPHPR3JKYEFS5ZDRRDVOLUHVANCNFSM5PXIA46Q>.
> You are receiving this because you authored the thread.
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.