Quarto tweaks #800
Merged
Quarto tweaks #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - switch to using bootstrap icons over font awesome icons - update card.ejs to allow for links
epinzur
reviewed
Oct 9, 2023
epinzur
reviewed
Oct 9, 2023
| if not shutil.which("quarto"): | ||
| session.error("Unable to execute `quarto`. Is it installed and in your path?\n" | ||
| "See https://quarto.org/docs/get-started/") | ||
|
|
There was a problem hiding this comment.
i wish nox had a way to call other nox commands before. like dependency running this one first. so we could avoid duplication like this.
it has a way to run other nox commands afterwards, but not before.
There was a problem hiding this comment.
Yep. I like that it lets us write Python to check things -- makes it easy for cases like this. I like that it makes it easy to run all python versions using virtualenvs. I'm watching wntrblm/nox#453 for dependency support (would be awesome to only build the maturin extension once, for instance).
It looks like https://github.com/rmorshea/noxopt#noxopt may be worth keeping an eye on too -- it would let us register a setup method for a prefix of the commands.
epinzur
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the community page
Also: