Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(common): Fix indentations / Delete redundant selfs & functions #169

Merged
merged 4 commits into from
Sep 30, 2020
Merged

refactor(common): Fix indentations / Delete redundant selfs & functions #169

merged 4 commits into from
Sep 30, 2020

Conversation

emrcftci
Copy link

  • Deleted unnecessary self's

  • Fixed indentations

  • Deleted unnecessary override functions

@emrcftci
refactor
a4aeedf 
- Deleted unnecessary self's

 - Fixed indentations

 - Deleted unnecessary override functions
@felipeflorencio
Copy link
Contributor

Can you take a look ?

@g20ready

@emrcftci emrcftci changed the title refactor refactor(common): Fix indentations / Delete redundant selfs & functions Nov 13, 2019
@emrcftci emrcftci closed this Nov 13, 2019
@emrcftci emrcftci reopened this Nov 13, 2019
@emrcftci
Copy link
Author

I solved conflicts in NFX.swift. So please take a look @g20ready 🚀 📱

@emrcftci
Copy link
Author

✅ I solved conflicts do you still interest in merge :) ? @felipeflorencio

@kasketis kasketis added this to the Release 1.20 milestone Sep 30, 2020
@kasketis kasketis changed the base branch from master to develop September 30, 2020 10:04
@kasketis kasketis merged commit 4cf3b69 into kasketis:develop Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeflorencio felipeflorencio Awaiting requested review from felipeflorencio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@emrcftci @felipeflorencio @kasketis