-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "GetMempoolEntriesByAddresses" to kaspad RPC. #2022
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2022 +/- ##
==========================================
+ Coverage 59.39% 59.46% +0.06%
==========================================
Files 671 675 +4
Lines 32028 32201 +173
==========================================
+ Hits 19023 19147 +124
- Misses 10276 10306 +30
- Partials 2729 2748 +19
Continue to review full report at Codecov.
|
} | ||
} | ||
|
||
if len(sending) > 0 || len(receiving) > 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to drop this if
. This way the index for each address entries will be predictable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this will result in each address having a MempoolEntryByAddress, even if sending / receving is empty. I would like to imitate the behaviour of GetUtxosByAddressess, to have some sort of standard. which i think leaves out all addresses that don't have utxo's. but i will look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment to reflect this discussion. The if statement will make this rpc call mimic GetUtxoEntriesByAddresses. Personally, i think all ByAddresses calls should follow the same convention / standard regarding addresses for which the call cannot find an "entry", in this case it would require the if statement, to exclude the address completely from the entries. But, if you insist I will happily oblige. Just wish to raise this point as a counter argument, before potentially changing this.
implements #1703
needed to fix #1984
Also hoping it will lead to other transaction and wallet improvements.