Wallet synchronization improvement #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
biospb
commented
Apr 15, 2022
biospb
commented
- Much faster sync on startup
- Avoid double scan of the same address range
* Much faster sync on startup * Avoid double scan of the same address range
|
I suspect this might be related to #2017. |
|
yes. this is fix for it |
Codecov Report
@@ Coverage Diff @@
## dev #2025 +/- ##
==========================================
- Coverage 59.41% 59.37% -0.04%
==========================================
Files 673 673
Lines 32332 32344 +12
==========================================
- Hits 19209 19205 -4
- Misses 10364 10379 +15
- Partials 2759 2760 +1
Continue to review full report at Codecov.
|
someone235
requested changes
Apr 26, 2022
| @@ -103,16 +112,24 @@ func (s *server) maxUsedIndex() uint32 { | |||
|
|
|||
| // collectRecentAddresses collects addresses from used addresses until | |||
| // the address with the index of the last used address + 1000. | |||
| // collectRecentAddresses scans addresses in batches of numIndexesToQuery, | |||
| // collectRecentAddresses scans addresses in batches of 1000, | |||
There was a problem hiding this comment.
So can you rename the const name to numIndexesToQueryForFarAddresses or something similar?
someone235
previously approved these changes
May 7, 2022
someone235
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.