Improved staging shard performance #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biospb
force-pushed
the
Staging-shard-improvement
branch
from
8dc4c0f
to
7de4ede
Compare
someone235
requested changes
Apr 29, 2022
| @@ -51,8 +52,16 @@ func (sa *StagingArea) Commit(dbTx DBTransaction) error { | |||
| return errors.New("Attempt to call Commit on already committed stagingArea") | |||
| } | |||
|
|
|||
| for _, shard := range sa.shards { | |||
| if shard == nil { // since sa.shards is an array and not a map, some shard slots might be empty. | |||
| // order by ID | |||
|
|
||
| for _, id := range keys { | ||
| shard, ok := sa.shards[id] | ||
| if !ok || shard == nil { |
There was a problem hiding this comment.
No need to compare to nil
using map instead of growing array as shard id can be 1000+ in some cases
biospb
force-pushed
the
Staging-shard-improvement
branch
from
7de4ede
to
2c1e234
Compare
someone235
previously approved these changes
May 4, 2022
Codecov Report
@@ Coverage Diff @@
## dev #2034 +/- ##
==========================================
- Coverage 59.42% 59.41% -0.01%
==========================================
Files 675 675
Lines 32213 32211 -2
==========================================
- Hits 19142 19139 -3
- Misses 10318 10323 +5
+ Partials 2753 2749 -4
Continue to review full report at Codecov.
|
someone235
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using map instead of extremely growing array