Add AcceptedTransactionIDs to ChainChanged notification and VirtualSelectedParentChain RPC #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponseMessage and VirtualSelectedParentChainChangedNotificationMessage
someone235
requested changes
Apr 29, 2022
app/rpc/manager.go
Outdated
| @@ -196,7 +196,7 @@ func (m *Manager) notifyVirtualSelectedParentChainChanged(virtualChangeSet *exte | |||
| defer onEnd() | |||
|
|
|||
| notification, err := m.context.ConvertVirtualSelectedParentChainChangesToChainChangedNotificationMessage( | |||
| virtualChangeSet.VirtualSelectedParentChainChanges) | |||
| virtualChangeSet.VirtualSelectedParentChainChanges, true) | |||
There was a problem hiding this comment.
You're populating the notification with tx data even if the user didn't subscribe to RPC notifications. I guess it could be a heavy operation.
Codecov Report
@@ Coverage Diff @@
## dev #2036 +/- ##
==========================================
+ Coverage 59.38% 59.49% +0.11%
==========================================
Files 675 675
Lines 32211 32296 +85
==========================================
+ Hits 19127 19213 +86
+ Misses 10333 10324 -9
- Partials 2751 2759 +8
Continue to review full report at Codecov.
|
svarogg
force-pushed
the
accepted-transaction-ids
branch
from
65a2841
to
696e651
Compare
someone235
requested changes
May 1, 2022
app/rpc/manager.go
Outdated
| virtualChangeSet.VirtualSelectedParentChainChanges, true) | ||
| if err != nil { | ||
| return err | ||
| if m.context.NotificationManager.DoesAnyListenerPropagateVirtualSelectedParentChainChanged() { |
There was a problem hiding this comment.
Can you also check if one of the listeners asked for transactions?
svarogg
force-pushed
the
accepted-transaction-ids
branch
from
bdcb91e
to
5119172
Compare
someone235
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was requested by TxBit, since it's complicated for them to follow balances tracking UTXO changes.
And example usage can be seen at: https://github.com/svarogg/kaspadotnet/blob/main/Kaspadotnet.Examples/FollowTransactions.cs