Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double pointer when passing rpcError to errors.As #2039

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

someone235
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2039 (9b4024a) into dev (540b0d3) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #2039      +/-   ##
==========================================
- Coverage   59.49%   59.43%   -0.06%     
==========================================
  Files         675      675              
  Lines       32213    32213              
==========================================
- Hits        19166    19147      -19     
- Misses      10301    10315      +14     
- Partials     2746     2751       +5     
Impacted Files Coverage Δ
app/rpc/rpchandlers/get_balance_by_address.go 0.00% <0.00%> (ø)
app/rpc/rpchandlers/get_balances_by_addresses.go 0.00% <0.00%> (ø)
app/appmessage/error.go 0.00% <0.00%> (-27.28%) ⬇️
...etadapter/server/grpcserver/protowire/rpc_error.go 75.00% <0.00%> (-25.00%) ⬇️
app/rpc/rpchandlers/get_mempool_entry.go 41.17% <0.00%> (-23.53%) ⬇️
...ructure/network/rpcclient/rpc_get_mempool_entry.go 45.45% <0.00%> (-18.19%) ⬇️
app/protocol/flows/v5/blockrelay/block_locator.go 52.94% <0.00%> (-11.77%) ⬇️
...rver/grpcserver/protowire/rpc_get_mempool_entry.go 66.66% <0.00%> (-6.07%) ⬇️
...ructure/network/rpcclient/grpcclient/grpcclient.go 76.56% <0.00%> (-4.69%) ⬇️
infrastructure/network/rpcclient/rpcclient.go 67.41% <0.00%> (-2.25%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540b0d3...9b4024a. Read the comment docs.

@someone235 someone235 merged commit 9ffbb15 into kaspanet:dev Apr 29, 2022
@someone235 someone235 deleted the add-pointer-to-rpc-error branch April 29, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants