Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase virtualChangeChan to 100e3 #2056

Merged
merged 4 commits into from
May 20, 2022
Merged

Conversation

someone235
Copy link
Collaborator

Don't crash when sending UTXO RPC notification to a closed route
Throw error if virtualChangeChan is full

Don't crash when sending UTXO RPC notification to a closed route
Throw error if virtualChangeChan is full
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2056 (cd23af0) into dev (48c7fa0) will increase coverage by 0.03%.
The diff coverage is 61.53%.

❗ Current head cd23af0 differs from pull request most recent head d68d9c6. Consider uploading reports for the commit d68d9c6 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2056      +/-   ##
==========================================
+ Coverage   59.36%   59.40%   +0.03%     
==========================================
  Files         673      673              
  Lines       32344    32351       +7     
==========================================
+ Hits        19200    19217      +17     
+ Misses      10383    10374       -9     
+ Partials     2761     2760       -1     
Impacted Files Coverage Δ
app/rpc/manager.go 73.55% <ø> (ø)
domain/consensus/consensus.go 68.52% <0.00%> (-0.25%) ⬇️
infrastructure/network/netadapter/router/route.go 85.00% <60.00%> (+2.14%) ⬆️
app/rpc/rpccontext/notificationmanager.go 58.90% <80.00%> (ø)
domain/domain.go 53.98% <100.00%> (ø)
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 53.03% <0.00%> (+0.40%) ⬆️
infrastructure/network/addressmanager/store.go 79.11% <0.00%> (+1.26%) ⬆️
...selectedchainstore/headers_selected_chain_store.go 75.58% <0.00%> (+3.48%) ⬆️
...k/netadapter/server/grpcserver/connection_loops.go 62.06% <0.00%> (+5.17%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c7fa0...d68d9c6. Read the comment docs.

@someone235 someone235 merged commit 4dd7113 into kaspanet:dev May 20, 2022
@someone235 someone235 deleted the crash-fix branch May 21, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants