Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OnBlockAdded event to the channel that was only used by virtualChanged events #2059

Merged
merged 6 commits into from
May 23, 2022

Conversation

svarogg
Copy link
Collaborator

@svarogg svarogg commented May 23, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2059 (1278183) into dev (4dd7113) will increase coverage by 0.02%.
The diff coverage is 63.44%.

❗ Current head 1278183 differs from pull request most recent head c10fafc. Consider uploading reports for the commit c10fafc to get more accurate results

@@            Coverage Diff             @@
##              dev    #2059      +/-   ##
==========================================
+ Coverage   59.32%   59.35%   +0.02%     
==========================================
  Files         673      674       +1     
  Lines       32355    32367      +12     
==========================================
+ Hits        19195    19210      +15     
+ Misses      10393    10390       -3     
  Partials     2767     2767              
Impacted Files Coverage Δ
app/protocol/flowcontext/blocks.go 68.67% <ø> (+0.49%) ⬆️
app/protocol/flowcontext/flow_context.go 92.59% <ø> (-0.52%) ⬇️
app/protocol/manager.go 84.21% <ø> (-0.79%) ⬇️
...in/consensus/model/externalapi/consensus_events.go 0.00% <0.00%> (ø)
...cesses/blockprocessor/validate_and_insert_block.go 70.09% <35.71%> (ø)
app/rpc/rpccontext/notificationmanager.go 59.44% <50.00%> (+0.54%) ⬆️
...sor/validate_and_insert_block_with_trusted_data.go 59.64% <50.00%> (ø)
app/rpc/manager.go 72.09% <64.70%> (-1.47%) ⬇️
domain/consensus/consensus.go 68.24% <75.00%> (-0.28%) ⬇️
app/component_manager.go 72.72% <100.00%> (-0.35%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd7113...c10fafc. Read the comment docs.

@someone235 someone235 merged commit 24c94b3 into kaspanet:dev May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants